Re: [ELPA] New package: buildbot.el

[Protesilaos Stavrou]

> From: Yuchen Pei <id@ypei.org>
> Date: Sun,  9 Jul 2023 13:04:01 +1000

Hello Yuchen,

> On Tue 2023-07-04 21:24:04 +1000, Yuchen Pei wrote:
>
>> On Mon 2023-06-26 17:53:03 +1000, Yuchen Pei wrote:
>>
>>> Hello everyone,
>>>
>>> I would like to submit buildbot.el (<https://g.ypei.me/buildbot.el.git>)
>>> to the GNU ELPA. It has been how I interact with Buildbot (except for
>>> retrying a build) for a few months now.
>>
>> Ping, can someone with access to ELPA upload the package please? Or
>> are there still issues in the way?
>
> Ping, any updates?
>
> According to the ELPA readme on adding a new package[1]:
>
> --8<---------------cut here---------------start------------->8---
> After 48 hours, or once any issues have been addressed, someone will push
> your changes for you.  You should probably also subscribe to
> [[https://lists.gnu.org/mailman/listinfo/emacs-devel][emacs-devel@gnu.org]], 
> since that's where we discuss about GNU ELPA, and
> to 
> [[https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs][bug-gnu-emacs@gnu.org]],
>  since that's where people will report bugs
> about your package.
> --8<---------------cut here---------------end--------------->8---
>
> It has been almost two weeks. Can someone honour the guidelines and push
> my package to ELPA please?
>
> [1] https://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/README

I will try to help though note that I have no means of testing buildbot.

Before checking the code of the package:

* You have assigned copyright to the Free Software Foundation and are
  the author/maintainer of the 'hcel' and 'luwak' GNU ELPA packages.

* The 'buildbot' dependency uses the GPL version 2 and is a member of
  the Software Freedom Conservancy.

Notes about the code in your buildbot.el:

1. The 'buildbot.el' file lacks a terminating comment (the "... ends
   here" part).  Your other files have it.

2. I notice that 'M-x checkdoc' returns a few issues in your files.
   Though, for example, in 'buildbot-client.el' they seem to be false
   positives.  Addressing those is not a priority.  I personally do it
   so that notes do not crowd out errors/warnings.

3. In 'buildbot-utils.el' the functions 'buildbot-url-fetch-json' and
   'buildbot-url-fetch-raw' can be consolidated.

4. In 'buildbot-view.el', you are defining key bindings in many
   places.  It may be easier to have them all in one place where the
   keymap is defined as a variable.

All the best,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com