[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 65108998b1e: docview: imenu: check return value of 'mutool'
From: |
Tassilo Horn |
Subject: |
Re: master 65108998b1e: docview: imenu: check return value of 'mutool' |
Date: |
Fri, 28 Jul 2023 06:56:30 +0200 |
User-agent: |
mu4e 1.11.12; emacs 30.0.50 |
Eli Zaretskii <eliz@gnu.org> writes:
>> > +(defcustom doc-view-imenu-enabled (executable-find "mutool")
>> > "Whether to generate an imenu outline when \"mutool\" is available."
>> > :type 'boolean
>> > :version "29.1")
>>
>> I'm not familiar with the code, so my apologies if this comment is
>> off, but the change above seems wrong. With this change,
>> `doc-view-imenu-enabled' becomes a string or nil which doesn't match
>> the boolean type. The (and ... t) part wasn't superfluous.
>
> This was okayed by Tassilo, so I'm adding him to this discussion.
Oh, I've not just okayed but actually smuggled in this logical
simplification into Morgan's patch which is obviously not correct in
this specific place. I've just fixed it on master.
Thanks for the heads-up and apologies, especially to Morgan.
Bye,
Tassilo