Re: make check produces 25 failures and hangs (bug #65176).

[Jens Schmidt]

On 2023-08-12  02:10, Po Lu wrote:

> > Repro-case-golfing, hoping that Andrea hasn't started on this yet:
> >
> > (require 'cl-lib)
> > (defun foo ()
> >    (interactive)
> >    (cl-letf (((symbol-function 'read-string) (lambda (&rest _) "bar")))
> >      (message (read-string "Prompt: "))))
>
> Isn't Fread_string a primitive, to which advice has no effect?

Not sure about native compilation and primitives, but on Emacs 29 the
natively compiled function `foo' behaves identically to the non-compiled
one (no prompt).  And ERTs rely on that pattern, and have been working
on master until they stopped doing so one or two weeks ago.