Re: make check produces 25 failures and hangs (bug #65176).

[Andrea Corallo]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Sun, 13 Aug 2023 12:59:26 +0200
>> Cc: acm@muc.de, yandros@gmail.com, emacs-devel@gnu.org,
>>  Po Lu <luangruo@yahoo.com>
>> From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
>> 
>> On 2023-08-12  21:09, Andrea Corallo wrote:
>> 
>> > To a very quick look seems to me `comp-subr-trampoline-install' is just
>> > not called as it should.  AFAIR it should be called from Ffset, I'm
>> > really wondering what could have happened.
>> 
>> Probably because native-comp-enable-subr-trampolines equals nil in an
>> "emacs-master -Q"?
>> 
>> When I compare the following snippet from emacs-master/lisp/loadup.el:
>> 
>>          (when (and (featurep 'native-compile)
>>                     (equal dump-mode "pdump"))
>>            ;; Don't enable this before bootstrap is completed, as the
>>            ;; compiler infrastructure may not be usable yet.
>>            (setq comp-enable-subr-trampolines t))
>>                  ^^^^
>> 
>> to emacs-29:
>> 
>>        (when (and (featurep 'native-compile)
>>                   (equal dump-mode "pdump"))
>>          ;; Don't enable this before bootstrap is completed, as the
>>          ;; compiler infrastructure may not be usable yet.
>>          (setq native-comp-enable-subr-trampolines t))
>>                ^^^^^^^^^^^
>
>
> These two are supposed to be aliases (the comp-enable-subr-trampolines
> one is the old name, the other one is the new name).
>
> If the alias is missing, we should restore it, in addition to fixing
> the name we use in startup.el.

Thanks Jens for the analysis and you for the fix.

We have in place the alias, but I guess when the code in loadup is
executed is to early and is maybe not effective?

Best Regards

  Andrea