[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Make ispell localwords safe local variable
|
From: |
Joseph Turner |
|
Subject: |
Re: [PATCH] Make ispell localwords safe local variable |
|
Date: |
Tue, 15 Aug 2023 18:41:18 -0700 |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Joseph Turner <joseph@breatheoutbreathe.in>
>> Date: Mon, 14 Aug 2023 22:40:24 -0700
>>
>> In this PR <https://github.com/alphapapa/makem.sh/pull/39>, we made it
>> possible for checkdoc/ispell to ignore localwords stored in a
>> .dir-locals.el when run in batch mode.
>>
>> It seemed appropriate to upstream this fix.
>
> I'm not sure this is indeed safe enough. We send these words to the
> spell-checker; are we sure this couldn't be abused by malicious people
> to perform some destructive actions?
I am not sure. Unless someone can be certain that ispell can safely
handle arbitrary strings, I think it's prudent to discard this patch.
Joseph