emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 508d24c8b9a 4/4: ; Silence byte-compiler


From: Basil L. Contovounesios
Subject: Re: master 508d24c8b9a 4/4: ; Silence byte-compiler
Date: Thu, 17 Aug 2023 11:29:13 +0200
User-agent: Gnus/5.13 (Gnus v5.13)

Stefan Kangas [2023-08-16 15:45 -0400] wrote:

> branch: master

Why not emacs-29?

> commit 508d24c8b9aee2c2a4c78ccfef3b5f551a1b2115
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
>
>     ; Silence byte-compiler
>     
>     * test/src/comp-tests.el (native-comp-eln-load-path): Declare.
> ---
>  test/src/comp-tests.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/test/src/comp-tests.el b/test/src/comp-tests.el
> index 2fd70585628..4444ab61219 100644
> --- a/test/src/comp-tests.el
> +++ b/test/src/comp-tests.el
> @@ -64,6 +64,7 @@
>  
>  
>  
> +(defvar native-comp-eln-load-path)
>  (ert-deftest comp-tests-bootstrap ()
>    "Compile the compiler and load it to compile it-self.
>  Check that the resulting binaries do not differ."

Would it be better to move the declaration within the test's body,
which is tagged as :nativecomp?  Or is the warning emitted in
--with-native-compilation builds as well?

Thanks,
-- 
Basil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]