Re: Policy for obsolete funcitons

[Andrea Corallo]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Andrea Corallo <acorallo@gnu.org>
>> Cc: emacs-devel@gnu.org
>> Date: Thu, 02 Nov 2023 14:51:33 -0400
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > If the function had a "--" in its name, it is an internal one and can
>> > be renamed.  Otherwise, we need to add an obsolete alias with the old
>> > name.
>>
>> Can't we use the argument that the entry points for the native compiler
>> are designed to be only the one we named native-*?
>
> It's hard to tell something this general.  I suggest to discuss
> specific functions you want to rename, if you have a list of them
> already.

Yes in comp-cstr.el the ones named without the doulbe dash and not
mentioned enywhere outside comp-cstr.el itself.  To a quick scan using
some scripting:

comp-cstr-intersection-make, comp-cstr-union-make, comp-cstr-symbol-p,
comp-cstr-union-1, comp-cstr-union-homogeneous,
comp-cstr-union-homogeneous-no-range, comp-cstr-sub-2, comp-cstr-add-2
comp-range-negation, comp-range-intersection, comp-range-union,
comp-intersect-typesets, comp-intersect-two-typesets,
comp-union-typesets comp-supertypes, comp-normalize-typeset,
comp-intersection-valsets comp-union-valsets, comp-normalize-valset,
comp-split-pos-neg comp-cstrs-homogeneous, comp-cstr-copy.

And similarly in comp.el:

comp-known-predicate-p, comp-pred-to-cstr,
comp-block-preds, comp-gen-counter,
comp-ensure-native-compiler,
comp-equality-fun-p, comp-arithm-cmp-fun-p, comp-set-op-p,
comp-assign-op-p, comp-call-op-p, comp-branch-op-p,
comp-type-hint-p, comp-func-unique-in-cu-p, comp-function-pure-p,
comp-alloc-class-to-container, comp-prettyformat-mvar,
comp-prettyformat-insn, comp-log-func, comp-log-edges,
comp-lex-byte-func-p, comp-spill-decl-spec, comp-spill-speed,
comp-decrypt-arg-list, comp-add-func-to-ctxt,
comp-intern-func-in-ctxt, comp-spill-lap, comp-lap-eob-p,
comp-lap-fall-through-p, comp-bb-maybe-add, comp-callref,
comp-new-frame, comp-emit, comp-emit-set-call, comp-copy-slot,
comp-make-curr-block, comp-latch-make-fill, comp-emit-uncond-jump,
comp-emit-cond-jump, comp-emit-handler, comp-limplify-listn,
comp-new-block-sym, comp-fill-label-h,
comp-jump-table-optimizable, comp-emit-switch,
comp-emit-set-call-subr, comp-op-to-fun, comp-body-eff,
comp-limplify-lap-inst, comp-emit-narg-prologue,
comp-limplify-finalize-function, comp-emit-lambda-for-top-level,
comp-limplify-top-level, comp-addr-to-bb-name,
comp-limplify-block, comp-limplify-function, comp-limplify,
comp-collect-mvars, comp-collect-rhs, comp-negate-arithm-cmp-fun,
comp-reverse-arithm-fun, comp-emit-assume, comp-maybe-add-vmvar,
comp-add-new-block-between, comp-cond-cstrs-target-mvar,
comp-add-cond-cstrs-target-block, comp-add-cond-cstrs-simple,
comp-add-cond-cstrs, comp-emit-call-cstr, comp-lambda-list-gen,
comp-add-call-cstr, comp-add-cstrs, comp-collect-calls,
comp-pure-infer-func, comp-ipa-pure, comp-clean-ssa,
comp-compute-edges, comp-collect-rev-post-order,
comp-compute-dominator-tree, comp-compute-dominator-frontiers,
comp-log-block-info, comp-place-phis, comp-dom-tree-walker,
comp-ssa-rename-insn, comp-ssa-rename, comp-finalize-phis,
comp-remove-unreachable-blocks, comp-ssa, comp-copy-insn,
comp-fwprop-prologue, comp-function-foldable-p,
comp-function-call-maybe-fold, comp-fwprop-call, comp-fwprop-insn,
comp-fwprop*, comp-rewrite-non-locals, comp-fwprop,
comp-func-in-unit, comp-call-optim-form-call,
comp-call-optim-func, comp-call-optim, comp-collect-mvar-ids,
comp-dead-assignments-func, comp-dead-code,
comp-form-tco-call-seq, comp-tco-func, comp-tco,
comp-remove-type-hints-func, comp-remove-type-hints,
comp-args-to-lambda-list, comp-compute-function-type,
comp-finalize-container, comp-finalize-relocs,
comp-compile-ctxt-to-file, comp-final1, comp-final,
comp-eln-load-path-eff,
comp-trampoline-filename, comp-make-lambda-list-from-subr,
comp-trampoline-search, comp-trampoline-compile,
comp-async-runnings, comp-effective-async-max-jobs,
comp-accept-and-process-async-output, comp-run-async-workers.

I think they are all very internal to the compiler machinery, they
tipically manipulate compiler specific kind of objects often requiring a
very specific contex setup in order not to error.

I can't see a use for them as generic library.  I think they should move
to the -- convention.

Thanks

  Andrea