Re: bytecomp-tests still failing after Mattias' commit a3db503351e9

[Jens Schmidt]

Changing subject (which I forgot last time) to catch Mattias' attention.

Mattias, could you please have a look?  Nothing has changed as of today's
commit 6218278a67b5ce87eb5e8b2c76daeb7475983d35, this one test is still
failing.  If you'd like to reproduce, you probably need to install package
bubblewrap or whatever provides "bwrap" on your distribution.  Provided
you use GNU/Linux ...

Thanks.

On 2023-10-30  21:24, Jens Schmidt wrote:

> This got much better (thanks), I'm down to one failing unit test now.
> And I think this last one is due to commit a3db503351e9 by Mattias.
> That commit should probably add the lexical bindings line in the
> mountpoint case, like this, which fixes the failure for me:
> 
> diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el 
> b/test/lisp/emacs-lisp/bytecomp-tests.el
> index 4aa555f1e92..06918f5901c 100644
> --- a/test/lisp/emacs-lisp/bytecomp-tests.el
> +++ b/test/lisp/emacs-lisp/bytecomp-tests.el
> @@ -1697,7 +1697,8 @@ bytecomp-tests--dest-mountpoint
>               (byte-compile-error-on-warn t))
>          (should-not (file-remote-p input-file))
>          (should-not (file-remote-p output-file))
> -        (write-region "" nil input-file nil nil nil 'excl)
> +        (write-region ";;; -*-lexical-binding:t-*-\n"
> +                      nil input-file nil nil nil 'excl)
>          (write-region "" nil output-file nil nil nil 'excl)
>          (unwind-protect
>              (progn
> 
> (Seems that I happen to have this "bwrap" thingy installed, otherwise that
> test gets skipped and may slip through.)
> 
> The failing test looks like this, if it matters:
> 
> ------------------------- snip -------------------------
> In end of data:
>  Warning: the function `an-undefined-function' is not known to be defined.
>    passed  15/99  bytecomp-test-featurep-warnings (0.000353 sec)
> Test bytecomp-tests--dest-mountpoint backtrace:
>   signal(ert-test-failed (((status . 1) (output . ">>Error occurred pr
>   ert-fail(((status . 1) (output . ">>Error occurred processing /tmp/e
>   (if (eql status 0) nil (ert-fail (list (cons 'status status) (cons '
>   (let ((status (call-process bwrap nil t nil "--ro-bind" "/" "/" "--b
>   (progn (let ((status (call-process bwrap nil t nil "--ro-bind" "/" "
>   (unwind-protect (progn (let ((status (call-process bwrap nil t nil "
>   (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
>   (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
>   (progn (set-file-modes input-file 256) (set-file-modes output-file 1
>   (unwind-protect (progn (set-file-modes input-file 256) (set-file-mod
>   (let* ((input-file (expand-file-name "test.el" directory)) (output-f
>   (progn (let* ((input-file (expand-file-name "test.el" directory)) (o
>   (unwind-protect (progn (let* ((input-file (expand-file-name "test.el
>   (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct
>   (let ((bwrap (executable-find "bwrap")) (emacs (expand-file-name inv
>   (closure (t) nil (let ((bwrap (executable-find "bwrap")) (emacs (exp
>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>   ert-run-test(#s(ert-test :name bytecomp-tests--dest-mountpoint :docu
>   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>   ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
>   ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
>   ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
>   command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/bytecomp-
>   command-line()
>   normal-top-level()
> Test bytecomp-tests--dest-mountpoint condition:
>     (ert-test-failed
>      ((status . 1)
>       (output .
>        ">>Error occurred processing /tmp/emacs-test-BIdKcv-bytecomp/test.el: 
> error ((\"file has no `lexical-binding' directive on its first line\"))\n")))
>    FAILED  16/99  bytecomp-tests--dest-mountpoint (0.056259 sec) at 
> lisp/emacs-lisp/bytecomp-tests.el:1681
> ------------------------- snip -------------------------