Re: master 5dc3c9f4eca 5/5: Mark treesit--things-around obsolete

[Po Lu]

Yuan Fu <casouri@gmail.com> writes:

> branch: master
> commit 5dc3c9f4eca2e3c4b4059cc5b52b56c98eb3d961
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
>
>     Mark treesit--things-around obsolete
>     
>     * lisp/treesit.el (treesit--things-around): Mark obsolete.
> ---
>  lisp/treesit.el | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/lisp/treesit.el b/lisp/treesit.el
> index 962b957b80c..45c5f313a8e 100644
> --- a/lisp/treesit.el
> +++ b/lisp/treesit.el
> @@ -2359,17 +2359,7 @@ the current line if the beginning of the defun is 
> indented."
>                         (line-beginning-position))
>           (beginning-of-line))))
>  
> -;; prev-sibling:
> -;; 1. end-of-node before pos
> -;; 2. highest such node
> -;;
> -;; next-sibling:
> -;; 1. beg-of-node after pos
> -;; 2. highest such node
> -;;
> -;; parent:
> -;; 1. node covers pos
> -;; 2. smallest such node
> +(make-obsolete 'treesit--things-around "`treesit--things-around' will be 
> removed in a few months, use `treesit--thing-prev', `treesit--thing-next', 
> `treesit--thing-at' instead." "30.0.5")
>  (defun treesit--things-around (pos thing)
>    "Return the previous, next, and parent thing around POS.
>  

Huh?

"30.0.50" (or other in-development version numbers) is never written in
contexts that call for version numbers; in defcustoms and suchlike,
always write the version of the forthcoming release, presently 30.1.

But moreover we don't obsolete internal functions with a promise to
remove them after an interlude several months in length.  (Once these
months elapse, you _will_ have forgotten.)  If they've never been used
outside Emacs, and particularly if they've not been released, such
functions are deleted immediately without delay or reservation.

Averse as I am to the brute deletion or obsoletion functions as a means
in itself, I believe this function merits such treatment.