Re: Adding support for xref jumping to headers/interfaces

[Dmitry Gutov]

On 11/11/2023 13:22, João Távora wrote:

> > > > Is that possible?
> > > For Dmitry to answer
> >
> > FWIW, the above is one of the alternatives that I had in mind when I
> > mentioned obsoleting the said commands.
> >
> > The other alternative looked like this, though:
> >
> > (make-obsolete 'eglot-find-declaration "use `xref-find-extra'" "...")
> > (make-obsolete 'eglot-find-implementation "use `xref-find-extra'" "...")
> > (make-obsolete 'eglot-find-typeDefinition "use `xref-find-extra'" "...")
>
> No, I'm not obsoleting those commands, sorry.  Not least because
> new LSP things may come along that xref.el won't be able to respond
> in time with.  So those commands are staying there.

So what if that happens? You'll add the new commands to Eglot then. Just 
like any other backend is supposed to do if they support commands not in 
the built-in set.

> The "declaration/implementation/typeDefinition" triplet is an LSP
> invention and Eglot is for LSP, so eglot- commands they will be,
> even if sometimes later in an eglot-commands.el file along with
> other ones.  And that's even if we do import that LSP invention
> into xref (which I think we shouldn't -- see my reply to Spencer).

Eglot is not the only LSP client for Emacs. I think there are about 4 of 
them at the moment...? Each with their own command definitions.