Re: master b2416d2c029 4/6: Don't load comp when installing an existing trampoline

[Stefan Monnier]

>> - The `declare-function` should be moved to right after (require
>>   'comp-run), i.e. when we do know that the function should be available
>>   and it will thus silence only spurious warnings.
>
> Ack will do, out of curiosity what is the downside of having the
> declare-function at top level?  I thought is there to silence a compile
> time warning (and thus the branch is inserted in should not play a
> role).

If you call that function from elsewhere in the file, there will be no
compilation warning, even though the call may error at run time because
`comp-run` wasn't loaded.

By moving the `declare-function` you make sure only those warnings that
you know for sure are spurious (because we just did `(require
'comp-run)`) will get silenced.

> As mentioned in the other thread I fear I don't remeber the answer to
> those quesitons.  The best we can do is to remove the call and test
> Emacs to find if there's still a good reason.

Then let's remove it in `master`.  This way, if it's needed we'll get to
see why/when and we'll be able to at the very least add a good comment,
or maybe replace it with a better solution.


        Stefan