Re: [ELPA] New package: ert-font-lock

[Vladimir Kazanov]

Hi Philip,

Thank you for taking a look at this!

I've integrated most of the changes but the ones below:

> +  ;; Or would it be possible to define a function that calls `ert-set-test'?

Sure, not a problem. But wouldn't the test implementation on this
level be just a replication of the already existing ert-deftest macro?
And ert-deftest, btw, does use half of cl-lib. Removing cl-incf just
stops making sense.

Admittedly, I don't have a bigger picture on Emacs Lisp idioms and
good practices so I'll just do whatever is suggested.

> +  (user-error "Invalid test comment syntax at line %d. Expected a line to 
> test before the comment line" curline)) ;is this a user error?

Well, I am on the fence about this one. My line of thought was that
submitting invalid test cases is very much a user error, isn't it?

> +    (or
> +     ;; skip empty lines
> +     (eolp)

I like the trick. But on empty lines this would return t instead of
only reporting comment lines.

On Sat, 18 Nov 2023 at 14:47, Philip Kaludercic <philipk@posteo.net> wrote:
>
> Po Lu <luangruo@yahoo.com> writes:
>
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> >> Doesn't this library require ert?  if it does, cl-lib is already
> >> loaded by ert.
> >
> > That's a disappointment, but let's not double the problem.
>
> The problem, as in the usage of cl-lib?  You are probably referring to
> the other thread about using CL in Elisp, right?
>
> >> But if people like cl-incf so much, we could just add incf to subr.el
> >> or something.
> >
> > Fine by me, thanks.  (Don't we have incf elsewhere in core?  Or was it
> > in the old cl.el?)
>
> That is part of cl, and is aliased to cl-incf.
>
> --
> Philip Kaludercic



-- 
Regards,

Vladimir Kazanov