emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Keep network security info buffers after use


From: Karl Fogel
Subject: [PATCH] Keep network security info buffers after use
Date: Sun, 17 Dec 2023 13:02:16 -0600
User-agent: Gnus/5.13 (Gnus v5.13)

What do people think of the attached behavior change?

Summary: after the user is prompted about whether to accept a remote cert, the buffer(s) with information about the cert should stay around, instead of being killed like they currently are.

Request: I'd like to know if people agree with the overall goal here. I'm still testing the change (I need to learn something new in order to test it -- namely, how to artifically "forget" a cert so that I get re-prompted again, and if anyone has tips on that, I'm all ears).

Motivation:

Recently I was sending an email from Emacs on a new machine, and I got prompted about whether to accept the remote SMTP server's cert. The prompt function is `nsm-query-user', and its manner of prompting didn't allow me to easily leave the minibuffer to go into the "*Network Security Manager*" buffer and grab the cert info so that I could save it to inspect further later on (maybe there was something I could have done with a recursive edit, but I didn't want to break my flow that much).

So after accepting the cert, I tried to go back to the "*Network Security Manager*" buffer to get the remote server fingerprint -- but alas, the buffer was gone.

Hence this change: make it so that that buffer (and another related cert-specific buffer) stay around after the user has been prompted, in case the user wants to go back and get the information in them.

I'm not sure whether just eliminating the calls to `kill-buffer' is enough. Maybe they should be replaced with `bury-buffer' calls, to make sure that those buffers aren't in the user's face? As I said above, I'm still testing. I'd just like to know if we agree with the goal of this change. I won't push it to master until a) I know we agree on the goal, and b) it's fully tested.

Best regards,
-Karl

Attachment: 0001-Keep-network-security-info-buffers-after-use.patch
Description: Keep network security info buffers after use


reply via email to

[Prev in Thread] Current Thread [Next in Thread]