Re: man broken?

[Philip Kaludercic]

Michael Albinus <michael.albinus@gmx.de> writes:

> Visuwesh <visuweshm@gmail.com> writes:
>
> Hi,
>
>> 1. emacs -Q
>> 2. M-: (require 'tramp-adb) RET
>> 3. M-x man RET ls RET
>>
>> This seems to be because connection-local-profile-alist has the adb
>> configuration which sets shell-file-name to "/system/bin/sh".
>
> Thanks for the recipe. I'll work on it when my health condition is going
> better, hopefully next days.

Could it be that this is the issue:

diff --git a/lisp/files-x.el b/lisp/files-x.el
index 41d9cd3bab8..1911afe43e0 100644
--- a/lisp/files-x.el
+++ b/lisp/files-x.el
@@ -1,6 +1,6 @@
 ;;; files-x.el --- extended file handling commands  -*- lexical-binding: t; -*-
 
-;; Copyright (C) 2009-2023 Free Software Foundation, Inc.
+;; Copyright (C) 2009-2024 Free Software Foundation, Inc.
 
 ;; Author: Juri Linkov <juri@jurta.org>
 ;; Maintainer: emacs-devel@gnu.org
@@ -704,7 +704,7 @@ connection-local-get-profiles
         profiles)
     (dolist (crit-alist connection-local-criteria-alist)
       (let ((crit criteria)
-            (match t))
+            (match nil))
         (while (and crit match)
           (when (plist-member (car crit-alist) (car crit))
             (setq match (equal (plist-get (car crit-alist) (car crit))

I am not quite sure what is going on in the function, but the invariant
is that match is always non-nil after the loop is done, which seems
suspicious to me.

> Best regrds, Michael.