emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 37889523278: Add new `swap` macro and use it


From: Eli Zaretskii
Subject: Re: master 37889523278: Add new `swap` macro and use it
Date: Sun, 07 Jan 2024 09:09:40 +0200

> From: Po Lu <luangruo@yahoo.com>
> Cc: stefankangas@gmail.com,  emacs-devel@gnu.org
> Date: Sun, 07 Jan 2024 09:39:30 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Then you could have easily fixed the change instead of reverting it,
> > right?  Why didn't you?
> 
> Because the change cannot be fixed in such a way that all affected
> systems will correctly build Emacs, and is impossible to implement in C.

Sorry, I don't understand.  AFAICT, something like

 #if SUN
 # define TYPEOF __typeof__
 #else
 # define TYPEOF __typeof
 #endif

would have solved the problem of the compiler with which you had the
problem.  If not, why not?  If the above would solve the problem, why
didn't you fix the commit that way, instead of reverting?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]