Re: master 37889523278: Add new `swap` macro and use it

[Eli Zaretskii]

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sat, 13 Jan 2024 02:02:53 -0600
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Regardless of portability issues, I think the macro should be called
> > SWAP, upper-case, to avoid clashes with functions.
> 
> Upper case more conventional for a macro, indeed.  I consider these
> three as exceptions: min, max, swap.  The former two, we already have.

min and max are standard names defined in many system headers.  So
they are exceptions rather than the rule.

> But I won't insist on using lower case also for `swap`, if you think
> it's better not to.
> 
> Do you think it's worth changing upper case function names to lower case
> also?  I find lower case names makes code more readable.

They are upper-case because they were macros once, and we kept the
letter-case for that reason.