|
| From: | Adam Porter |
| Subject: | Re: [ELPA] New package: activities |
| Date: | Fri, 26 Jan 2024 04:48:51 -0600 |
| User-agent: | Mozilla Thunderbird |
Hi Eshel,
FWIW, I think a spot a small mistake in `activities-completing-read`: passing the value of the history variable to `completing-read` instead of the variable name. Also, it seems like the commands that use this function expect an existing "activity", so would it make sense to accept only matching inputs? That is, making the following change:
Thanks for catching those. I pushed a fix and mentioned you in the commit message.
--Adam
| [Prev in Thread] | Current Thread | [Next in Thread] |