emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-t


From: Po Lu
Subject: Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes
Date: Sat, 27 Jan 2024 16:05:20 +0800
User-agent: Gnus/5.13 (Gnus v5.13)

Eli Zaretskii <eliz@gnu.org> writes:

>> Why was this installed on emacs-29?  It is no bugfix.
>
> Bug#68708 claims that this is a bugfix.

??? That is a Coreutils bug.  But I see bug#68705 in the bug tracker
now.

> Btw, Yuan: please always mention the bug number in the commit log
> messages.  If you install someone else's change via "git am", and the
> author didn't mention the bug number, please use "git commit --amend"
> afterwards to add the bug number (or modify the log message in any
> other way), before you push.

Yes, please.  Furthermore, if such bugfix cannot be described as
anything but a simplification (with a correspondingly large diff), there
should be another approach safer for the release branch.

Quoting Yuan's response on the bug tracker:

> Thanks Randy, pushed to emacs-29 since it includes a fix.
>
> Yuan

Our basic criterion for installing patches on emacs-29 is not whether a
change contains a bugfix, but whether it runs a risk of destablizing the
branch.  It is more important that a bugfix be the only component of a
change, since that reduces the probability of unanticipated disruption.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]