emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-t


From: Po Lu
Subject: Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes
Date: Sun, 28 Jan 2024 09:34:15 +0800
User-agent: Gnus/5.13 (Gnus v5.13)

Stefan Kangas <stefankangas@gmail.com> writes:

> Po Lu <luangruo@yahoo.com> writes:
>
>> Yes, please.  Furthermore, if such bugfix cannot be described as
>> anything but a simplification (with a correspondingly large diff), there
>> should be another approach safer for the release branch.
>
> We must not get overly rigid about that.  It takes extra work, and it
> will not always be clear that it's worth the effort.  Often it is, but
> sometimes it isn't.  We tend to decide on a case-by-case basis.
>
> Furthermore, please keep in mind that Yuan is both the principal author
> and maintainer of our treesitter support.  He's closer to the code than
> anyone else, and is thus in the best position to make such judgement
> calls.  I see no reason to second-guess him here, myself.

The burden of proof is on the author of the patch, who might be the most
qualified person to comment on tree-sitter, but certainly not imenu,
autoloads, or other areas of Emacs no less affected by this change.  The
bug fix in this change should have been separately installed on
emacs-29, with the rest on master.

> If there are any specific technical arguments for why this particular
> change must not be installed on emacs-29, then let's hear them.  Neither
> generalizations nor administrative arguments will cut it, I think.

I haven't heard any specific technical arguments as to why this change
is safe.  Rather, I'm the person who is frequently told that such
specific statements regarding the safety of a large change are "famous
last words"--which they are, all too often, so I have taken that advice
to heart.

> The above does not necessarily reflect the official line of the project.

??? I was summarizing what I myself have been told and observed over a
certain length of time.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]