Re: [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require

[Stefan Monnier]

> diff --git a/lisp/ox-bibtex.el b/lisp/ox-bibtex.el
> index 743fd7da2a..8cdf390cf2 100644
> --- a/lisp/ox-bibtex.el
> +++ b/lisp/ox-bibtex.el
> @@ -157,9 +157,11 @@ to `org-bibtex-citation-p' predicate."
>  (defvar org-bibtex-file nil
>    "Org file of BibTeX entries.")
>  
> +(declare-function obe-citations "org-bibtex-extras" ())
>  (defun org-bibtex-goto-citation (&optional citation)
>    "Visit a citation given its ID."
>    (interactive)
> +  (require 'org-bibtex-extras)
>    (let ((citation (or citation (completing-read "Citation: " 
> (obe-citations)))))
>      (find-file (or org-bibtex-file
>                  (error "`org-bibtex-file' has not been configured")))

The `declare-function` should be placed right next (after) the
`require`.  In practice it (currently) makes no difference (because of
technical details of how `declare-function` is (currently) implemented),
but in theory it clarifies that you do not intend to claim that it's safe
to call `obe-citations` from anywhere within `ox-bibtex`, but only from
within `org-bibtex-goto-citation`.


        Stefan