Re: master 78fc49407b8 1/3: Improve filling of ChangeLog entries

[João Távora]

On Wed, Jan 31, 2024 at 11:19 AM Po Lu <luangruo@yahoo.com> wrote:

>  I don't doubt that these particular `cl-loop' or `pcase'
> forms are simple to understand, provided that the reader takes the ten
> or so minutes to absorb the relevant portions of their documentation.

As I said, I'd just use edebug or macroexpand these things away, like
I did.  You do know edebug, right?  And pp-macroexpand?  The latter
takes not even 10 seconds, what 10 minutes!??

Also, do you have any remote idea how much time it will take someone
to read your code which has grown those functions 3 or 4 fold??

> avocational projects such as Emacs, where I make a mental note of tasks
> that interest me, and pick the least time-consuming of them to complete
> whenever free time (which, surprising as it may be, is scarce) does come
> my way.

Judging by the number of follow-up bugfix commits, you misjudged that
badly.

> Which is also the reason I requested no more than that you not install
> your version now, leaving the door open to future improvement on your
> terms once I finish making it work.

Of course not, it's now yours.  Probably forever.

The unit tests are basically the only thing I can read from
your code.  Really, in practice you'll be probably be the only one ever
reading that long-winded Fotran-like code, so I wish you stick around
for a long time maintaining it.

The only "improvement" I'd have is reverting all your work and
applying my succinct patch that meets the current goalposts.
If you move them or invent new ones that's another matter... hopefully
that will also come with tests, or even some minimal discussion.

So while the code would go back to being simpler (even without cl-loop)
 you'd probably be demotivated to keep maintaing the file.  Also
the history is already botched, I'd just make it worse.  Really doesn't
justify rewriting your code. It'd be a poor, almost ridiculous, way to
"collaborate".

> diatribe was unnecessary (and I'm not certain I disagree with
> most of it)

If, in all that sea of bravado, it has dropped a grain of self-doubt
for next time you're pulling out the bulldozer, I consider it a diatribe
well tribed.

Anyway, have fun, and all the best
João