Re: discoverability, better defaults and which-key in Emacs

[Po Lu]

Dmitry Gutov <dmitry@gutov.dev> writes:

> diff --git a/src/keyboard.c b/src/keyboard.c
> index 10cdef67348..8cc1b2ec756 100644
> --- a/src/keyboard.c
> +++ b/src/keyboard.c
> @@ -594,14 +594,9 @@ echo_dash (void)
>                   concat2 (KVAR (current_kboard, echo_string), dash));
>  
>    if (echo_keystrokes_help)
> -    {
> -      Lisp_Object help;
> -
> -      help = build_string (" (\\`C-h' or \\`<f1>' for help)");
> -      kset_echo_string (current_kboard,
> -                     concat2 (KVAR (current_kboard, echo_string),
> -                              calln (Qsubstitute_command_keys, help)));
> -    }
> +    kset_echo_string (current_kboard,
> +                   calln (intern_c_string ("help--append-keystrokes-help"),
> +                          KVAR (current_kboard, echo_string)));
>  
>    echo_now ();
>  }

Please replace the call to intern_c_string with a DEFSYM.  There's no
good reason not to.