Re: Missing snprintf in ucrt mingw + vc-refresh in find-file hook?

[Arthur Miller]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Arthur Miller <arthur.miller@live.com>
>> Cc: emacs-devel@gnu.org
>> Date: Tue, 13 Feb 2024 10:47:33 +0100
>> 
>> I wasn't even aware this was going on, untill yesterday. I understand that 
>> some
>> users like to see diverse stuff in their modeline, statusbars, powerlines,
>> command prompts and other widgets. That is fine; if users want it, give it to
>> them.
>> 
>> But I am not such a user, and this feels a bit too much to have it auto
>> on. This can get triggered automatically in save places; for example I have 
>> save
>> place on, so when I open a file, Emacs will display cursor at the same place
>> where I left. I see that it gets triggred in some places with Helm
>> completion. Basically everything I have nowdays is in Git, inclusive my 
>> entire
>> emacs.d folder. That means I am constantly starting and killing git 
>> processes,
>> and I don't even care about that info on my modeline. I look barely at 
>> modeline;
>> sometimes I take a look at the clock or line/column number.
>
> I understand your POV, but this is turned on by default in Emacs long
> ago.  So the default cannot be changed just because you personally
Yes, I have already understood that from the replies ysterday :). I never
realized that was going on under the hood. If you don't want to change the
defualt at least let us have an easy way to disable it. 

> dislike it.  Instead, I suggest that you change the default value of
> mode-line format locally.  Or remove vc-refresh-state from

I don't think it even shows on my modeline; I have no idea even where in the
modline to look for it. My modeline is already very simplified, with most of the
stuff diminished or removed. As said, I noticed first from that backtrace
yesterday.

> find-file-hook.  Or try playing with the value of vc-display-status.
> Or some other change that could do what you want; look in vc-hooks.el
> for ideas.

Yes, I did play with vc-display-status; setting it to nil does not do what you
suggest it will do. It still triggers git process.

I have to manually remove the vc-refresh from the hook for find-file. At least
in 29.2_1 or turn-off everything by setting backends to nil.

I see in the master that code for vc-display-status has changed and there are
some options now, but there is no :set function and option to completely disable
it. I haven't built yet from the master, so I can't tell how well it works to
just choose 'backend as an option in this regards.

There is also the save file stuff which is implemented differently. As I asked
Dmitry, is there any special reason why is it not implemented via
after-save-hook? If it isn't I can hack it and use after-save-hook instead which
than lets me to simply hack defcustom for vd-display-status with :set function
to add/remove vc-refresh to/from relevant hooks.

>> If you consider that people are complaining quite a lot about Emacs been too
>> slow on Windows, than I would consider if this is something that has to be 
>> on by
>> default.
>
> Git is not slow on MS-Windows; I posted the numbers I measured to show
> that.  Git is just much faster on GNU/Linux, so people who are
> accustomed to its speed on the latter complain when they need to work
> on the former.  IOW, it's a "relative complaint", not an "absolute
> complaint".

Yesterday, about an hour after I sent email here, someone posted this claiming
that git interactions slow down vc-mode:

https://www.reddit.com/r/emacs/comments/1ahx90f/if_you_would_like_a_new_feature_in_emacs_v30_what/kq2sxml/?context=3

It could be a moot or it could be something in it; I don't know.

I don't know why people experience that Emacs is slow on Windows.I experience it
myself too and I haven't blamed it on anything specific yet. I have thoughts
that it perhaps is mingw/msys runtime; but I don't know. I didn't say Git
specific is slow. Perhaps it is a combination of things that make Emacs slow. I
don't know. You are monitoring Reddit every day more or less, and see yourself
that people are not complaining on anything specifically.

Anyway, regardless of how fast Git or Emacs are, if I do not value to see some
statusline update, I don't think I should spend CPU cycles and battery life on
it, regardless how slow or fast it may be.