Re: MPS: weak hash tables

[Gerd Möllmann]

Helmut Eller <eller.helmut@gmail.com> writes:

> On Sun, Jul 07 2024, Gerd Möllmann wrote:
>
>>>> Oh, I think I found something! "messages" is a let-bound variable
>>>> containing all messages. The backtrace goes there. But the backtrace
>>>> also prints the values of let-bound variables in closures, so it'll
>>>> print all messages recursively, giving us O(N^2) behavior at least...
>>>
>>> Hm, messages is let-bound in ert-test-run-tests-batch-expensive.  How
>>> can it have any effect or be effected by other tests?
>>
>> I thought it maybe comes from here
>>
>>   (defun ert-run-tests (selector listener &optional interactively)
>>     "Run the tests specified by SELECTOR, sending progress updates to 
>> LISTENER."
>>     (let* ((tests (ert-select-tests selector t))
>>            (stats (ert--make-stats tests selector)))
>>
>> Haven't checked that though, the lines were too long for me.
>
> You mean "stats", which includes results and possibly big objects of the
> previous tests, is included in the backtrace.  And
> ert-test-run-tests-batch-expensive prints it with altered printer
> settings.  Could be.

Yes, something like that. I couldn't find something global that could be
the culprit, so it should be something above the frames of the current
test. How that exactly works with stats being a lexical variable I don't
know though.