emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: scratch/igc 90e80a9a53e 6/6: Adjust igc.c code to header changes


From: Eli Zaretskii
Subject: Re: scratch/igc 90e80a9a53e 6/6: Adjust igc.c code to header changes
Date: Sun, 21 Jul 2024 19:27:18 +0300

> Date: Sun, 21 Jul 2024 16:20:57 +0000
> From: Pip Cet <pipcet@protonmail.com>
> Cc: emacs-devel@gnu.org
> 
> > Why cannot you identify this kind of object during dumping, and avoid
> > applying whatever igc_dump_finish_obj does?
> 
> You mean you'd prefer to leave the pseudovector header for builtin subrs at 
> its current value? We can do that, but I think the MPS header should still be 
> valid. (It's not with the patch I had attached: that makes it claim an object 
> size of 112 bytes when it's actually just 96 bytes, and that causes us to 
> overwrite the first 16 bytes after the last subr; in my case, stdout... 
> Anyway, next patch attached, which duplicates a bit of code unnecessarily.)

Then why doesn't your patch do that?  And this new patch is even more
massive than the previous one?

In any case, if we need to change the definition of Aligned_Lisp_Subr,
let's do that only "#if HAVE_MPS", and leave the old code intact.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]