Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback)

[Manuel Giraud]

Tassilo Horn <tsdh@gnu.org> writes:

> Manuel Giraud via "Emacs development discussions." <emacs-devel@gnu.org> 
> writes:
>
> Hi Manuel,
>
>>> -(defface doc-view-svg-face '((t :inherit default))
>>> +(defface doc-view-svg-face '((t :inherit default
>>> +                                :background "white"
>>> +                                :foreground "black"))
>>
>> Since this face is used only for its foreground and background colors,
>> I think you could leave the :inherit.
>
> I know.  But that makes it slightly easier to turn on styling by theme.
> Or, well, having both nil without inheriting has the same effect, but as
> you have said, explicit is better.  I agree with that, so I kept it on
> purpose.

Ah ok.  You're right it is easier to configure via custom.  Thanks.
-- 
Manuel Giraud