Re: [ELPA] some tex-related packages

[Philip Kaludercic]

Paul Nelson <ultrono@gmail.com> writes:

> Hi Philip, many thanks for your feedback.  I've implemented the
> requested changes.

(suggested, not required; the code is very good overall!)

> I had a couple quick questions:
>
> 1. Just for my own understanding, could you explain the following
> idiom, which shows up in a couple places in your comments on
> tex-parens?  Why do we have two fboundp's?
>
> (and (fboundp 'avy-jump)
>     (require 'avy nil t)
>     (fboundp 'avy-jump))

I should have explained that, my idea was to check if avy-jump was
actually made available by the `require' or not.  But I wouldn't
describe it as an idiom, or an elegant solution.  All I wanted to avoid
was that loading avy by hand is required after installing it as well.

> 2.
>
>> Again, nothing special to say.  I just think you should include cl-lib
>> and seq (or just one of the two).
>
> Just to make sure I understand, this means to add (require 'seq)?

You were using both cl- and seq- functions.  I was suggesting to make
that explicit by `require'ing them as well.  IIRC the code using seq-
and the code cl- functions could have also respectively been written in
the other style, so I thought it wouldn't be bad to stick to one of the
two inside a single package.

Other than that, we can add the packages to ELPA, right?

> Thanks, best,
>
> Paul

-- 
        Philip Kaludercic on siskin