[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 103ae72ee9f 1/2: New unit-tests for cl-lib (bug#75633).
From: |
Basil L. Contovounesios |
Subject: |
Re: master 103ae72ee9f 1/2: New unit-tests for cl-lib (bug#75633). |
Date: |
Sun, 02 Feb 2025 16:40:36 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Pip Cet via "Emacs development discussions." [2025-02-02 14:00 +0000] wrote:
> I'm therefore proposing this patch. Okay to push to master?
I think the patch in https://bugs.gnu.org/75633#16 already covers the
warnings (and other preexisting issues) specifically in cl-seq-tests.el.
I was giving Ahmed some time to respond before applying the patch, but
it's been a week so I can do that today.
In the bug report I also asked about the test duplication across
cl-extra-tests.el, cl-lib-tests.el, cl-macs-tests.el, and
cl-seq-tests.el.
I think tests exercising the same definition should be put in the same
-tests.el file to help prevent duplicated efforts.
Is it okay to move those (older) tests in cl-lib-tests.el that exercise
definitions not from cl-lib.el to the more specific -tests.el file?
Or the other way around?
Thanks,
--
Basil