Re: master 1437fc2bca2: Enable yanking non-Latin-1 primary selections in I-Search

[Stefan Monnier]

>> Thanks.  I think I'm beginning to see.  It makes me think that maybe we
>> should deprecate the use of `gui-get-selection` without an explicit
>> DATA-TYPE argument, WDYT?
> That's a rather extreme measure, if by deprecate you mean obsolete.

Why extreme?  It would still behave the same, just emitting
a compilation warning when called with an insufficient number
of arguments.  Also, it's not a wildly popular function:
I see only 5 users in (Non)GNU ELPA and about as many in Emacs itself.
So it's not like our users/developers would drown under a deluge of
compilation warnings.

BTW, maybe another option would be to change the default DATA-TYPE from
`STRING` (which IIUC is limited to latin-1 and is thus not an acceptable
option nowadays) to `UTF8_STRING` (which seems to be what ends up used
in my case during `gui-get-value-selection`)?

> IMO it should be more than sufficient to insert some admonition to the
> same effect into its doc string, actually _deprecating_ invocations of
> this function without explicitly specifying a data type.

We have a tradition of helping the programmers discover those things via
compiler warnings than forcing them to read etc/NEWS and then try and
figure out that "their" code is affected.


        Stefan