[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix OSX build without pdumper
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] Fix OSX build without pdumper |
Date: |
Thu, 20 Mar 2025 14:09:47 +0200 |
> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, Gerd Möllmann
> <gerd@gnu.org>, emacs-devel@gnu.org
> Date: Wed, 19 Mar 2025 21:42:15 +0100
>
> Jindrich Makovicka <makovick@gmail.com> writes:
>
> > On Wed, 2025-03-19 at 15:44 +0100, Gerd Möllmann wrote:
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >>
> >> > > +ifeq (${DUMPING},pdumper)
> >> > > ${INSTALL_DATA} src/emacs.pdmp
> >> > > "$(DESTDIR)${libexecdir}/Emacs.pdmp"
> >> > > +endif
> >> > > subdir=${ns_appresdir}/site-lisp && ${write_subdir}
> >> > > rm -rf ${ns_appresdir}/share
> >> > > endif
> >> >
> >> > Thanks. I don't know enough about the macOS builds, so let's ask
> >> > Gerd, who added that line. Gerd, does this change look correct to
> >> > you and safe enough to install on the release branch?
> >>
> >> I think the change would work, but I'm confused, TBH. For one thing,
> >> I
> >> didn't know that anyone builds without pdumper on macOS (and how that
> >> works), and secondly, are we talking about the Python distribution
> >> "Anaconda" here? And if so, what's going on that it doesn't use the
> >> pdumper?
> >
> > Thanks for the prompt replies - yes, this is related to Anaconda (which
> > was originally a Python distro that evolved into a full fledged distro
> > that does not need root to manage).
> >
> > This issue is triggered by cross-compilation for arm64 on amd64 build
> > host when configured "--with-pdumper=yes --with-unexec=no --with-
> > dumping=none". AFAICS the cross compiled conda package disables
> > pdumping in the build phase, and postpones it to the installation of
> > the package by the user.
> >
> > I actually don't know much about OSX either (and especially about cross
> > compilation) - I am using the Linux version.
>
> Cross compilation was what didn't cross my mind. Thanks for the explanation!
Thanks, installed on the emacs-30 release branch.