|
From: | Fabián Ezequiel Gallina |
Subject: | Re: [Emacs-diffs] /srv/bzr/emacs/trunk r110472: Fix shell handling of unbalanced quotes and parens in output. |
Date: | Mon, 08 Oct 2012 23:20:20 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120910 Thunderbird/15.0.1 |
On 10/08/2012 09:34 PM, Stefan Monnier wrote:
(set (make-local-variable 'syntax-propertize-function) - python-syntax-propertize-function)) + (syntax-propertize-rules + (comint-prompt-regexp + (0 (ignore + (put-text-property + comint-last-input-start end 'syntax-table + python-shell-output-syntax-table) + (font-lock-unfontify-region comint-last-input-start end))))Calling font-lock-unfontify-region from syntax-propertize looks wrong. So it at least deserves a detailed comment explaining the problem ut's trying to fix and why you decided to do it this way. Stefan
Agreed, I just wanted to clean fontification after adding new syntax properties and that seemed the way to go. I'll see if I can come with something better or I'll add a commentary explaining that.
Regards, Fabián
[Prev in Thread] | Current Thread | [Next in Thread] |