[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
master 55ad194 2/2: Fix <button>...</button> submit button rendering in
From: |
Lars Ingebrigtsen |
Subject: |
master 55ad194 2/2: Fix <button>...</button> submit button rendering in eww |
Date: |
Thu, 20 Feb 2020 08:44:25 -0500 (EST) |
branch: master
commit 55ad194922d357e7ee2c0d728a51dbfee54bcf0c
Author: Lars Ingebrigtsen <address@hidden>
Commit: Lars Ingebrigtsen <address@hidden>
Fix <button>...</button> submit button rendering in eww
* lisp/net/eww.el (eww-form-submit): Use the contents of the
<button>...</button> for the string if there is no value
(bug#39326).
---
lisp/net/eww.el | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 811d7c6..c83884f 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1107,11 +1107,13 @@ just re-display the HTML already fetched."
(defun eww-form-submit (dom)
(let ((start (point))
(value (dom-attr dom 'value)))
- (setq value
- (if (zerop (length value))
- "Submit"
- value))
- (insert value)
+ (if (null value)
+ (shr-generic dom)
+ (insert value))
+ ;; If the contents of the <button>...</button> turns out to be
+ ;; empty, or the value was blank, default to this:
+ (when (= (point) start)
+ (insert "Submit"))
(add-face-text-property start (point) 'eww-form-submit)
(put-text-property start (point) 'eww-form
(list :eww-form eww-form