emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 4ae315f7c3: Fix potential (goto-char nil) in byte-compile-warning


From: Alan Mackenzie
Subject: master 4ae315f7c3: Fix potential (goto-char nil) in byte-compile-warning-prefix
Date: Mon, 20 Jun 2022 14:32:29 -0400 (EDT)

branch: master
commit 4ae315f7c3b5bc370d9d66eab5428685a6097606
Author: Alan Mackenzie <acm@muc.de>
Commit: Alan Mackenzie <acm@muc.de>

    Fix potential (goto-char nil) in byte-compile-warning-prefix
    
    * lisp/emacs-lisp/bytecomp.el (byte-compile-warning-prefix): Replace a wrong
    'or' form involving OFFSET with simply OFFSET.  This prevents OFFSET from
    possibly being nil in the first branch of the containing `if' form.
---
 lisp/emacs-lisp/bytecomp.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 2ae9aa13bb..198eb4df5c 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1246,8 +1246,7 @@ Order is by depth-first search."
                                      load-file-name dir)))
                     (t "")))
          (offset (byte-compile--warning-source-offset))
-        (pos (if (and byte-compile-current-file
-                       (or offset (not symbols-with-pos-enabled)))
+        (pos (if (and byte-compile-current-file offset)
                  (with-current-buffer byte-compile-current-buffer
                     (let (new-l new-c)
                       (save-excursion



reply via email to

[Prev in Thread] Current Thread [Next in Thread]