[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
master f01024b94d 1/2: Avoid recording passwords' chars
From: |
Eli Zaretskii |
Subject: |
master f01024b94d 1/2: Avoid recording passwords' chars |
Date: |
Sat, 25 Jun 2022 05:34:42 -0400 (EDT) |
branch: master
commit f01024b94d1b2af9ebb14a2d1faaddce23314811
Author: Manuel Giraud <manuel@ledu-giraud.fr>
Commit: Eli Zaretskii <eliz@gnu.org>
Avoid recording passwords' chars
* lisp/cus-start.el (standard): New user custom `record-all-keys'.
* src/keyboard.c (syms_of_keyboard): Un-obsolete
`inhibit--record-char'.
* lisp/subr.el (read-passwd): Use `inhibit--record-char' to
inhibit passwords recording.
---
etc/NEWS | 6 ++++++
lisp/cus-start.el | 1 +
lisp/subr.el | 7 +------
src/keyboard.c | 18 ++++++++++++++++++
4 files changed, 26 insertions(+), 6 deletions(-)
diff --git a/etc/NEWS b/etc/NEWS
index e3b4df227e..afd0725a69 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -398,6 +398,12 @@ This inhibits putting empty strings onto the kill ring.
These options allow adjusting point and scrolling a window when
dragging items from another program.
++++
+** New user option 'record-all-keys'.
+If non-nil, this option will force recording of all input keys
+including in passwords prompt (this was the previous behaviour). It
+now defaults to NIL and inhibits recording of passwords.
+
+++
** New function 'command-query'.
This function makes its argument command prompt the user for
diff --git a/lisp/cus-start.el b/lisp/cus-start.el
index d8c4b48035..ca2fca4eb7 100644
--- a/lisp/cus-start.el
+++ b/lisp/cus-start.el
@@ -398,6 +398,7 @@ Leaving \"Default\" unchecked is equivalent with specifying
a default of
;; (const :tag " current dir" nil)
;; (directory :format "%v"))))
(load-prefer-newer lisp boolean "24.4")
+ (record-all-keys keyboard boolean)
;; minibuf.c
(minibuffer-follows-selected-frame
minibuffer (choice (const :tag "Always" t)
diff --git a/lisp/subr.el b/lisp/subr.el
index 075bfb95b7..b05471f0c3 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -1883,12 +1883,6 @@ be a list of the form returned by `event-start' and
`event-end'."
(make-obsolete-variable 'load-dangerous-libraries
"no longer used." "27.1")
-(defvar inhibit--record-char nil
- "Obsolete variable.
-This was used internally by quail.el and keyboard.c in Emacs 27.
-It does nothing in Emacs 28.")
-(make-obsolete-variable 'inhibit--record-char nil "28.1")
-
(define-obsolete-function-alias 'compare-window-configurations
#'window-configuration-equal-p "29.1")
@@ -3048,6 +3042,7 @@ by doing (clear-string STRING)."
(use-local-map read-passwd-map)
(setq-local inhibit-modification-hooks nil) ;bug#15501.
(setq-local show-paren-mode nil) ;bug#16091.
+ (setq-local inhibit--record-char t)
(add-hook 'post-command-hook #'read-password--hide-password nil t))
(unwind-protect
(let ((enable-recursive-minibuffers t)
diff --git a/src/keyboard.c b/src/keyboard.c
index 7fb7afca87..0d52378a93 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -3320,6 +3320,11 @@ help_char_p (Lisp_Object c)
static void
record_char (Lisp_Object c)
{
+ /* subr.el/read-passwd binds inhibit_record_char to avoid recording
+ passwords. */
+ if (!record_all_keys && inhibit_record_char)
+ return;
+
int recorded = 0;
if (CONSP (c) && (EQ (XCAR (c), Qhelp_echo) || EQ (XCAR (c),
Qmouse_movement)))
@@ -13026,6 +13031,19 @@ argument, which is the terminal on which the monitor
configuration
changed. */);
Vdisplay_monitors_changed_functions = Qnil;
+ DEFVAR_BOOL ("inhibit--record-char",
+ inhibit_record_char,
+ doc: /* If non-nil, don't record input events.
+This inhibits recording input events for the purposes of keyboard
+macros, dribble file, and `recent-keys'.
+Internal use only. */);
+ inhibit_record_char = false;
+
+ DEFVAR_BOOL ("record-all-keys", record_all_keys,
+ doc: /* Non-nil means to record all typed keys. When
+nil, only passwords' keys are not recorded. */);
+ record_all_keys = false;
+
pdumper_do_now_and_after_load (syms_of_keyboard_for_pdumper);
}