emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 0b62ad2f3a: Fix configure.ac quoting of AC_CHECK_LIB's 2nd arg


From: Eli Zaretskii
Subject: master 0b62ad2f3a: Fix configure.ac quoting of AC_CHECK_LIB's 2nd arg
Date: Tue, 28 Jun 2022 07:28:40 -0400 (EDT)

branch: master
commit 0b62ad2f3a57845c664965658da82ffc93cb6e26
Author: Jim Meyering <meyering@fb.com>
Commit: Eli Zaretskii <eliz@gnu.org>

    Fix configure.ac quoting of AC_CHECK_LIB's 2nd arg
    
    Running an autoconf-head-generated configure, would fail like this:
      /emacs/configure: line 18002: syntax error near unexpected token `;;'
      /emacs/configure: line 18002: `  ;;'
    That is due to under-quoting of AC_CHECK_LIB's second argument, which led to
    the comma in an embedded string being interpreted as paramater-delimiting.
    * configure.ac: Quote the second arg of each AC_CHECK_LIB invocation.
    (Bug#56272)
    
    Copyright-paperwork-exempt: yes
---
 configure.ac | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index c91b7de322..17f86627a7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3622,7 +3622,7 @@ if test "${HAVE_X11}" = "yes"; then
        CFLAGS="$CFLAGS $XFT_CFLAGS"
        LIBS="$XFT_LIBS $LIBS"
        AC_CHECK_HEADER(X11/Xft/Xft.h,
-         AC_CHECK_LIB(Xft, XftFontOpen, HAVE_XFT=yes, , $XFT_LIBS) , ,
+          [AC_CHECK_LIB(Xft, XftFontOpen, HAVE_XFT=yes, , $XFT_LIBS)] , ,
           [[#include <X11/X.h>]])
 
        if test "${HAVE_XFT}" = "yes"; then
@@ -3818,7 +3818,7 @@ AC_SUBST(M17N_FLT_LIBS)
 XCB_LIBS=
 if test "${HAVE_X11}" = "yes"; then
   AC_CHECK_HEADER(X11/Xlib-xcb.h,
-    AC_CHECK_LIB(xcb, xcb_translate_coordinates, HAVE_XCB=yes))
+    [AC_CHECK_LIB(xcb, xcb_translate_coordinates, HAVE_XCB=yes)])
   if test "${HAVE_XCB}" = "yes"; then
     AC_CHECK_LIB(X11-xcb, XGetXCBConnection, HAVE_X11_XCB=yes)
     if test "${HAVE_X11_XCB}" = "yes"; then
@@ -4597,7 +4597,7 @@ XSYNC_CFLAGS=
 HAVE_XSYNC=no
 if test "${HAVE_X11}" = "yes"; then
    AC_CHECK_HEADER(X11/extensions/sync.h,
-     AC_CHECK_LIB(Xext, XSyncQueryExtension, HAVE_XSYNC=yes),
+     [AC_CHECK_LIB(Xext, XSyncQueryExtension, HAVE_XSYNC=yes)],
      [], [#include <X11/Xlib.h>])
 
   if test "${HAVE_XSYNC}" = "yes"; then



reply via email to

[Prev in Thread] Current Thread [Next in Thread]