[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
emacs-29 173e02f4eb 2/3: ; Fix doc string in ERC's module-activation com
From: |
F. Jason Park |
Subject: |
emacs-29 173e02f4eb 2/3: ; Fix doc string in ERC's module-activation commands |
Date: |
Fri, 16 Dec 2022 09:37:01 -0500 (EST) |
branch: emacs-29
commit 173e02f4eb41853a60d4532d76c3c67324da05a8
Author: F. Jason Park <jp@neverwas.me>
Commit: F. Jason Park <jp@neverwas.me>
; Fix doc string in ERC's module-activation commands
* lisp/erc/erc-common.el (erc--assemble-toggle): Previously, the doc
string implied that a prefix argument was necessary to achieve
connection-wide effects, which might lead a person to think the
interactive code should be an uppercase "P".
* test/lisp/erc/erc-tests.el (define-erc-module--local): Update
expected result of code-gen.
---
lisp/erc/erc-common.el | 3 ++-
test/lisp/erc/erc-tests.el | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/lisp/erc/erc-common.el b/lisp/erc/erc-common.el
index e662c06daa..da75d50d61 100644
--- a/lisp/erc/erc-common.el
+++ b/lisp/erc/erc-common.el
@@ -130,7 +130,8 @@ canonical name.")
(if val "Enable" "Disable")
" ERC " (symbol-name name) " mode."
(when localp
- "\nWith ARG, do so in all buffers for the current connection."))
+ (concat "\nWhen called interactively,"
+ " do so in all buffers for the current connection.")))
(interactive ,@(when localp '("p")))
,@(if localp
`((when (derived-mode-p 'erc-mode)
diff --git a/test/lisp/erc/erc-tests.el b/test/lisp/erc/erc-tests.el
index 51c562f525..578b2641a6 100644
--- a/test/lisp/erc/erc-tests.el
+++ b/test/lisp/erc/erc-tests.el
@@ -1331,7 +1331,7 @@ Some docstring"
(defun erc-mname-enable (&optional ,arg-en)
"Enable ERC mname mode.
-With ARG, do so in all buffers for the current connection."
+When called interactively, do so in all buffers for the current connection."
(interactive "p")
(when (derived-mode-p 'erc-mode)
(if ,arg-en
@@ -1343,7 +1343,7 @@ With ARG, do so in all buffers for the current
connection."
(defun erc-mname-disable (&optional ,arg-dis)
"Disable ERC mname mode.
-With ARG, do so in all buffers for the current connection."
+When called interactively, do so in all buffers for the current connection."
(interactive "p")
(when (derived-mode-p 'erc-mode)
(if ,arg-dis