emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 3b038d46e24 2/4: Remove useless handling of erroneous code in Lis


From: Mattias Engdegård
Subject: master 3b038d46e24 2/4: Remove useless handling of erroneous code in Lisp optimiser
Date: Fri, 5 May 2023 16:01:33 -0400 (EDT)

branch: master
commit 3b038d46e24532bc4bca56f37d30afd70fae388d
Author: Mattias Engdegård <mattiase@acm.org>
Commit: Mattias Engdegård <mattiase@acm.org>

    Remove useless handling of erroneous code in Lisp optimiser
    
    * lisp/emacs-lisp/byte-opt.el (byte-optimize-form-code-walker):
    ((closure ...) ...) is a malformed function call; treat it as such.
    Better malformed function warning location.
---
 lisp/emacs-lisp/byte-opt.el | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el
index d859706c180..d046c4d401c 100644
--- a/lisp/emacs-lisp/byte-opt.el
+++ b/lisp/emacs-lisp/byte-opt.el
@@ -469,10 +469,6 @@ for speeding up processing.")
             form
           (byte-optimize-form newform for-effect))))
 
-      ;; FIXME: Strictly speaking, I think this is a bug: (closure...)
-      ;; is a *value* and shouldn't appear in the car.
-      (`((closure . ,_) . ,_) form)
-
       (`(setq ,var ,expr)
        (let ((lexvar (assq var byte-optimize--lexvars))
              (value (byte-optimize-form expr nil)))
@@ -500,7 +496,7 @@ for speeding up processing.")
        (cons fn (mapcar #'byte-optimize-form exps)))
 
       (`(,(pred (not symbolp)) . ,_)
-       (byte-compile-warn-x fn "`%s' is a malformed function" fn)
+       (byte-compile-warn-x form "`%s' is a malformed function" fn)
        form)
 
       ((guard (when for-effect



reply via email to

[Prev in Thread] Current Thread [Next in Thread]