emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master f37c65b402f: * src/eval.c (get_backtrace): Don't skip the top fra


From: Stefan Monnier
Subject: master f37c65b402f: * src/eval.c (get_backtrace): Don't skip the top frame
Date: Sat, 22 Jul 2023 17:35:56 -0400 (EDT)

branch: master
commit f37c65b402f8a054fed9a3d6234cb7f85da3621a
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    * src/eval.c (get_backtrace): Don't skip the top frame
    
    `profiler.el` was reporting incomplete backtraces.
    I had a suspicion there was something off, but it became obvious
    when I saw that `set-buffer-multibyte` did not appear in the
    `profiler-report` output when opening a large compressed tarball,
    even though I knew it to be a large contributor (which `elp-results`
    confirmed).
    
    I have no idea why this `backtrace_next` was there, sadly, but now
    `profiler-report` gives me results that make a lot more sense.
---
 src/eval.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/eval.c b/src/eval.c
index 3f4e77cd3b1..9e54d489a3b 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -4203,7 +4203,7 @@ mark_specpdl (union specbinding *first, union specbinding 
*ptr)
 void
 get_backtrace (Lisp_Object array)
 {
-  union specbinding *pdl = backtrace_next (backtrace_top ());
+  union specbinding *pdl = backtrace_top ();
   ptrdiff_t i = 0, asize = ASIZE (array);
 
   /* Copy the backtrace contents into working memory.  */



reply via email to

[Prev in Thread] Current Thread [Next in Thread]