[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/elpa d2eca65 045/139: Fix another Flymake sync bug
From: |
Jo�o T�vora |
Subject: |
[elpa] externals/elpa d2eca65 045/139: Fix another Flymake sync bug |
Date: |
Mon, 14 May 2018 09:53:32 -0400 (EDT) |
branch: externals/elpa
commit d2eca65b86acea1e7ce293f737806affec8f89c4
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>
Fix another Flymake sync bug
* eglot.el (eglot-flymake-backend): Only report unreported sometimes.
(eglot--maybe-activate-editing-mode): Start flymake explicitly
when didOpen.
(eglot--textDocument/publishDiagnostics): No need to set
unreported-diagnostics to nil.
(flymake): Require it.
---
eglot.el | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/eglot.el b/eglot.el
index ccf4b72..3561da2 100644
--- a/eglot.el
+++ b/eglot.el
@@ -32,6 +32,7 @@
(require 'pcase)
(require 'compile) ; for some faces
(require 'warnings)
+(require 'flymake)
(defgroup eglot nil
"Interaction with Language Server Protocol servers"
@@ -657,12 +658,11 @@ running. INTERACTIVE is t if called interactively."
message))))
into diags
finally
- (if (null eglot--current-flymake-report-fn)
- (setq eglot--unreported-diagnostics
- diags)
- (funcall eglot--current-flymake-report-fn
- diags)
- (setq eglot--unreported-diagnostics nil))))))
+ (if eglot--current-flymake-report-fn
+ (funcall eglot--current-flymake-report-fn
+ diags)
+ (setq eglot--unreported-diagnostics
+ diags))))))
(t
(eglot--message "OK so %s isn't visited" filename)))))
@@ -724,7 +724,8 @@ that case, also signal textDocument/didOpen."
(and proc (eq proc cur)))
(unless eglot-editing-mode
(eglot-editing-mode 1))
- (eglot--signalDidOpen)))))
+ (eglot--signalDidOpen)
+ (flymake-start)))))
(add-hook 'find-file-hook 'eglot--maybe-activate-editing-mode)
@@ -947,10 +948,11 @@ Records START, END and LENGTH locally."
(defun eglot-flymake-backend (report-fn &rest _more)
"An EGLOT Flymake backend.
Calls REPORT-FN maybe if server publishes diagnostics in time."
- ;; Call immediately with anything unreported (this will clear any
- ;; pending diags)
- (funcall report-fn eglot--unreported-diagnostics)
- (setq eglot--unreported-diagnostics nil)
+ ;; Maybe call immediately if anything unreported (this will clear
+ ;; any pending diags)
+ (when eglot--unreported-diagnostics
+ (funcall report-fn eglot--unreported-diagnostics)
+ (setq eglot--unreported-diagnostics nil))
;; Setup so maybe it's called later, too.
(setq eglot--current-flymake-report-fn report-fn)
;; Take this opportunity to signal a didChange that might eventually
- [elpa] externals/elpa 1dc2a9f 021/139: Implement spinners and RLS's window/progress, (continued)
- [elpa] externals/elpa 1dc2a9f 021/139: Implement spinners and RLS's window/progress, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa 95983c9 028/139: Change status to error everytime an error is found, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa 328c7ae 025/139: Auto update mode-line after setting some process properties, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa 2775dea 003/139: Rename eglot--continuations eglot--pending-continuations, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa 75495dc 033/139: Slightly more user friendly start, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa 6f6f01d 018/139: Doc fixes, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa 0ec7801 012/139: Simplify `eglot--protocol-initialize`, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa 88e3655 040/139: Appease checkdoc.el, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa f7f77e1 044/139: Make M-x eglot the main entry point, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa 51ff863 046/139: Must re-announce didOpen after reconnect, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa d2eca65 045/139: Fix another Flymake sync bug,
Jo�o T�vora <=
- [elpa] externals/elpa c95a0a4 041/139: Multiple servers per project are possible, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa e60c7fc 013/139: Overhaul async mechanism safety, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa a3545fb 050/139: Rename RPC methods for clarity, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa 4d4b85d 061/139: eglot-editing-mode becomes eglot--managed-mode, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa 4f246b5 017/139: * eglot.el (eglot-mode-map): Move up before minor mode., Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa a4f99e0 005/139: Introduce and use `eglot--current-process-or-lose', Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa 8e6488f 023/139: Don't switch to possibly dead buffer in sentinel, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa be52e1e 037/139: Rework connection restarting again, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa cc183a6 043/139: Fix assorted bugs, Jo�o T�vora, 2018/05/14
- [elpa] externals/elpa e8f859e 031/139: Rework commands for connecting and reconnecting, Jo�o T�vora, 2018/05/14