[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] master 3c906cd 15/34: Always offer completions (workaround for co
From: |
Vitalie Spinu |
Subject: |
[elpa] master 3c906cd 15/34: Always offer completions (workaround for company issue #476) |
Date: |
Tue, 7 May 2019 16:05:27 -0400 (EDT) |
branch: master
commit 3c906cd6e1115615a3c59fbdb4b4202ccd7541af
Author: Clément Pit--Claudel <address@hidden>
Commit: Clément Pit--Claudel <address@hidden>
Always offer completions (workaround for company issue #476)
The issue appears clearly when one wants to insert unicode symbols with
short LaTeX names, such as ‘\Cap’, ‘\wp’, or ‘\wr’. The problem is that
company-mode closes its popup if there is only one completion available,
and it has been typed in full. In that case, even running
‘company-manual-begin’ has no effect; the only way to insert the
corresponding unicode symbol is to remove the last character of the
symbol, and to run ‘company-manual-begin’.
This commit introduces the workaround discussed in
https://github.com/company-mode/company-mode/issues/476: we add a space
at the end of each symbol in ‘company-math-symbols-unicode’, to ensure
that the user can always use ‘RET’ to insert Unicode symbols.
---
company-math.el | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/company-math.el b/company-math.el
index 7f944ed..bf9d0e0 100644
--- a/company-math.el
+++ b/company-math.el
@@ -147,9 +147,13 @@ corresponding unicode symbol."
(cl-case command
(interactive (company-begin-backend 'company-math-symbols-unicode))
(prefix (company-math--prefix company-math-allow-unicode-symbols-in-faces
-
company-math-disallow-unicode-symbols-in-faces))
+
company-math-disallow-unicode-symbols-in-faces))
(annotation (concat " " (get-text-property 0 :symbol arg)))
- (candidates (all-completions arg company-math--symbols))
+ ;; Space added to ensure that completions are never typed in full.
+ ;; See https://github.com/company-mode/company-mode/issues/476
+ (candidates (mapcar (lambda (candidate)
+ (concat candidate " "))
+ (all-completions arg company-math--symbols)))
(post-completion (company-math--substitute-unicode
(get-text-property 0 :symbol arg)))))
- [elpa] master c970a21 03/34: Adjust to `math-symbol-lists` name change, (continued)
- [elpa] master c970a21 03/34: Adjust to `math-symbol-lists` name change, Vitalie Spinu, 2019/05/07
- [elpa] master 9a960df 02/34: Readme, Vitalie Spinu, 2019/05/07
- [elpa] master 7999062 01/34: Add initial stuff, Vitalie Spinu, 2019/05/07
- [elpa] master f5cedcf 12/34: Use generic `tex-mode-hook` in readme, Vitalie Spinu, 2019/05/07
- [elpa] master 8190924 07/34: [#1] Fix typo in readme, Vitalie Spinu, 2019/05/07
- [elpa] master e82c91d 10/34: Bump version, Vitalie Spinu, 2019/05/07
- [elpa] master 8e64cae 17/34: Untabify and add .dir-locals, Vitalie Spinu, 2019/05/07
- [elpa] master 55f0a03 08/34: require cl-lib, Vitalie Spinu, 2019/05/07
- [elpa] master 9407824 21/34: Company doesn't like nils, remove those, Vitalie Spinu, 2019/05/07
- [elpa] master 96e55e6 20/34: [Fix #8] Don't propose Unicode completions if no Ucode, Vitalie Spinu, 2019/05/07
- [elpa] master 3c906cd 15/34: Always offer completions (workaround for company issue #476),
Vitalie Spinu <=
- [elpa] master d0db15e 13/34: [Fix #6] Add `tex-math` to `company-math-allow-latex-symbols-in-faces`, Vitalie Spinu, 2019/05/07
- [elpa] master 26bf67b 34/34: [company-math] Merge from upstream, Vitalie Spinu, 2019/05/07
- [elpa] master a8a98e3 24/34: [Fix #11] Don't require at least one character in prefix regexp, Vitalie Spinu, 2019/05/07
- [elpa] master ce46d91 16/34: Merge pull request #7 from cpitclaudel/always-offer-completions, Vitalie Spinu, 2019/05/07
- [elpa] master 2cb03c4 23/34: Version 1.2, Vitalie Spinu, 2019/05/07
- [elpa] master 0263e9c 27/34: [Fix #12] Make default sub/super-script prefix __ and ^^, Vitalie Spinu, 2019/05/07
- [elpa] master 3481f03 32/34: Merge pull request #15 from Kaligule/patch-1, Vitalie Spinu, 2019/05/07
- [elpa] master e89ddb2 31/34: Enable latex backend in org-mode per default, Vitalie Spinu, 2019/05/07
- [elpa] master 6ffd24c 22/34: Implement unicode sub(super)scripting, Vitalie Spinu, 2019/05/07
- [elpa] master 1ab4b8e 29/34: Allow nil in sub/super-script prefix customization, Vitalie Spinu, 2019/05/07