[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] master 9e03f36 095/184: ivy-test.el: Turn two tests back on
From: |
Oleh Krehel |
Subject: |
[elpa] master 9e03f36 095/184: ivy-test.el: Turn two tests back on |
Date: |
Wed, 16 Oct 2019 13:14:58 -0400 (EDT) |
branch: master
commit 9e03f36388155178cbb29dadefed10ea0459a23d
Author: Oleh Krehel <address@hidden>
Commit: Oleh Krehel <address@hidden>
ivy-test.el: Turn two tests back on
The reason why they were failing is that they require `ivy-mode' to be
on, and ERT runs tests in a random order. So previously these tests
were not failing because a previous test turned `ivy-mode' on.
Fixes #2215
---
ivy-test.el | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/ivy-test.el b/ivy-test.el
index 1bd6974..9a645fd 100644
--- a/ivy-test.el
+++ b/ivy-test.el
@@ -950,10 +950,7 @@ will bring the behavior in line with the newer Emacsen."
(should (eq (ivy--sort-function 'c) fn1))))
(ert-deftest ivy-read-directory-name ()
- :expected-result (if (and (= emacs-major-version 24)
- (= emacs-minor-version 5))
- :failed
- :passed)
+ (ivy-mode 1)
(should
(equal (expand-file-name "/tmp/")
(ivy-with
@@ -1039,11 +1036,7 @@ a buffer visiting a file."
(ivy-mode ivy-mode-reset-arg)))
(ert-deftest ivy-read-file-name-make-directory ()
- :expected-result (if (and (= emacs-major-version 24)
- (= emacs-minor-version 5))
- ;; result is "/tmp/non-existant-dir/\n" for some reason
- :failed
- :passed)
+ (ivy-mode 1)
(should
(equal
(ivy-with
- [elpa] master e4e0ec4 049/184: counsel.el (counsel--file-name-filter): Return "cat" on empty input, (continued)
- [elpa] master e4e0ec4 049/184: counsel.el (counsel--file-name-filter): Return "cat" on empty input, Oleh Krehel, 2019/10/16
- [elpa] master 17d9c70 036/184: counsel.el (counsel--find-return-list): Re-use counsel--call, Oleh Krehel, 2019/10/16
- [elpa] master 44c4bab 057/184: Restore use-ignore setting on ivy-resume, Oleh Krehel, 2019/10/16
- [elpa] master d3e4514 063/184: Remove obsolete aliases older than one year, Oleh Krehel, 2019/10/16
- [elpa] master 0be5b58 067/184: ivy.el (ivy-partial): Don't rely on subr-x, Oleh Krehel, 2019/10/16
- [elpa] master a986e4e 071/184: ivy.el (ivy--yank-handle-case-fold): Add, Oleh Krehel, 2019/10/16
- [elpa] master e41cbec 073/184: ivy.el (ivy-immediate-done): Fix parent dirs for read-directory-name, Oleh Krehel, 2019/10/16
- [elpa] master 3256447 076/184: ivy.el (ivy--partial-cd-for-single-directory): Extract, Oleh Krehel, 2019/10/16
- [elpa] master 03b3f82 075/184: ivy.el (ivy-partial): Use ivy--filter in place of all-completions, Oleh Krehel, 2019/10/16
- [elpa] master daf4683 081/184: ivy.el (ivy--directory-done): Inhibit distracting TRAMP message for /sudo::, Oleh Krehel, 2019/10/16
- [elpa] master 9e03f36 095/184: ivy-test.el: Turn two tests back on,
Oleh Krehel <=
- [elpa] master 4b7b075 093/184: ivy-test.el (ivy-test-inhibit-message): Add, Oleh Krehel, 2019/10/16
- [elpa] master 967d046 091/184: ivy-test.el (counsel-yank-pop): Fix on Windows, Oleh Krehel, 2019/10/16
- [elpa] master cfbf481 089/184: Lazy load ffap, Oleh Krehel, 2019/10/16
- [elpa] master 464875a 103/184: counsel.el (counsel-mark-ring): Refactor for reducing nested let, Oleh Krehel, 2019/10/16
- [elpa] master 0c1901e 100/184: ivy.el (ivy--regex-ignore-order): Fix docstring, Oleh Krehel, 2019/10/16
- [elpa] master 6905e6c 097/184: counsel.el (counsel--rg-targets): Adjust for ivy-occur buffers, Oleh Krehel, 2019/10/16
- [elpa] master e6171e2 098/184: ivy-hydra.el (ivy-dispatching-done-hydra): Fix for ivy-resume, Oleh Krehel, 2019/10/16
- [elpa] master 943eb01 108/184: counsel.el (counsel-mark-ring): Goto actual point instead of line, Oleh Krehel, 2019/10/16
- [elpa] master 36045f7 003/184: doc/Changelog.org: Fixup, Oleh Krehel, 2019/10/16
- [elpa] master 4389a26 056/184: ivy-overlay.el (ivy-overlay-show-after): Check window height better, Oleh Krehel, 2019/10/16