[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/eglot 1671dc4 12/69: Fix #209: protect against null mes
From: |
João Távora |
Subject: |
[elpa] externals/eglot 1671dc4 12/69: Fix #209: protect against null messages from eldoc |
Date: |
Sun, 20 Oct 2019 08:21:43 -0400 (EDT) |
branch: externals/eglot
commit 1671dc487aaac8f1a32089c8388fff98cc157f58
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>
Fix #209: protect against null messages from eldoc
* eglot.el (eglot--eldoc-message): Protect against nil FORMAT.
---
eglot.el | 41 +++++++++++++++++++++--------------------
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/eglot.el b/eglot.el
index d251bcb..799ab10 100644
--- a/eglot.el
+++ b/eglot.el
@@ -2070,26 +2070,27 @@ Buffer is displayed with `display-buffer', which obeys
:type 'boolean)
(defun eglot--eldoc-message (format &rest args)
- (let ((string (apply #'format format args))) ;; FIXME: overworking?
- (when (or (eq t eglot-put-doc-in-help-buffer)
- (funcall eglot-put-doc-in-help-buffer string))
- (with-current-buffer (eglot--help-buffer)
- (rename-buffer (format "*eglot-help for %s*" eglot--eldoc-hint))
- (let ((inhibit-read-only t))
- (erase-buffer)
- (insert string)
- (goto-char (point-min))
- (if eglot-auto-display-help-buffer
- (display-buffer (current-buffer))
- (unless (get-buffer-window (current-buffer))
- (eglot--message
- "%s\n(...truncated. Full help is in `%s')"
- (truncate-string-to-width
- (replace-regexp-in-string "\\(.*\\)\n.*" "\\1" string)
- (frame-width) nil nil "...")
- (buffer-name eglot--help-buffer))))
- (help-mode)
- t)))))
+ (when format
+ (let ((string (apply #'format format args))) ;; FIXME: overworking?
+ (when (or (eq t eglot-put-doc-in-help-buffer)
+ (funcall eglot-put-doc-in-help-buffer string))
+ (with-current-buffer (eglot--help-buffer)
+ (rename-buffer (format "*eglot-help for %s*" eglot--eldoc-hint))
+ (let ((inhibit-read-only t))
+ (erase-buffer)
+ (insert string)
+ (goto-char (point-min))
+ (if eglot-auto-display-help-buffer
+ (display-buffer (current-buffer))
+ (unless (get-buffer-window (current-buffer))
+ (eglot--message
+ "%s\n(...truncated. Full help is in `%s')"
+ (truncate-string-to-width
+ (replace-regexp-in-string "\\(.*\\)\n.*" "\\1" string)
+ (frame-width) nil nil "...")
+ (buffer-name eglot--help-buffer))))
+ (help-mode)
+ t))))))
(defun eglot-eldoc-function ()
"EGLOT's `eldoc-documentation-function' function.
- [elpa] externals/eglot 4398934 01/69: Fix #198: prevent Eldoc flicker when moving around, (continued)
- [elpa] externals/eglot 4398934 01/69: Fix #198: prevent Eldoc flicker when moving around, João Távora, 2019/10/20
- [elpa] externals/eglot d6a6de7 03/69: Fix test failure introduced by previous commit, João Távora, 2019/10/20
- [elpa] externals/eglot e69cca9 06/69: * README.md: Remove funny UTF character., João Távora, 2019/10/20
- [elpa] externals/eglot 9377988 02/69: Per #198: Show large docs in help buffer instead of echo are by default, João Távora, 2019/10/20
- [elpa] externals/eglot e5e5125 04/69: Rename new defcustoms with friendlier names, João Távora, 2019/10/20
- [elpa] externals/eglot cba3987 07/69: README.md: minor cosmetic tweaks, João Távora, 2019/10/20
- [elpa] externals/eglot dc371b8 08/69: Display truncated docstring if too large for echo area, João Távora, 2019/10/20
- [elpa] externals/eglot 17ec29b 14/69: Per #177: consider mode derivation when guessing servers, João Távora, 2019/10/20
- [elpa] externals/eglot fcb8ab6 11/69: Per #121: fix bug introduced by commit fixing this issue, João Távora, 2019/10/20
- [elpa] externals/eglot 5fc7ecc 10/69: Add built-in support for Dart's dart_language_server, João Távora, 2019/10/20
- [elpa] externals/eglot 1671dc4 12/69: Fix #209: protect against null messages from eldoc,
João Távora <=
- [elpa] externals/eglot dbf2dd2 20/69: * eglot.el (xref-backend-references): Don't use return-from., João Távora, 2019/10/20
- [elpa] externals/eglot 3ecdef1 09/69: Fix #201: handle label offsets in ParameterInformation, João Távora, 2019/10/20
- [elpa] externals/eglot 40a3d8c 16/69: Fix broken python formatting tests, João Távora, 2019/10/20
- [elpa] externals/eglot 1c6c30f 17/69: Disable another test on Travis, João Távora, 2019/10/20
- [elpa] externals/eglot d65d139 15/69: Don't teardown company if started via trigger chars, João Távora, 2019/10/20
- [elpa] externals/eglot 7d6e3cf 21/69: Per #220: unbreak build, João Távora, 2019/10/20
- [elpa] externals/eglot b868ee1 23/69: Fix #260: Only consider Eglot's own diagnostics in eglot-code-actions, João Távora, 2019/10/20
- [elpa] externals/eglot 5f629eb 26/69: Add built-in support for Elixir's elixir-ls (#264), João Távora, 2019/10/20
- [elpa] externals/eglot 356100a 19/69: Fix #220: don't sort xref's by default, João Távora, 2019/10/20
- [elpa] externals/eglot 195c311 22/69: Fix local function call in directory watcher (#255), João Távora, 2019/10/20