[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/eglot ae0943f 40/54: Revert the last change about colum
From: |
Jo�o T�vora |
Subject: |
[elpa] externals/eglot ae0943f 40/54: Revert the last change about column calculation |
Date: |
Thu, 16 Apr 2020 05:31:51 -0400 (EDT) |
branch: externals/eglot
commit ae0943f5d96776b41c4151beb6edabe0d6c43762
Author: Felicián Németh <address@hidden>
Commit: Felicián Németh <address@hidden>
Revert the last change about column calculation
---
NEWS.md | 9 ---------
eglot.el | 12 ++++++------
2 files changed, 6 insertions(+), 15 deletions(-)
diff --git a/NEWS.md b/NEWS.md
index ef6b5f3..0b4cb9e 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,13 +1,5 @@
# 1.6 (upcoming)
-##### Column offset calculation is now LSP-conform ([#361][github#361])
-
-It seems the majority of servers now comply with the language server
-specification when it comes to handling non-ASCII texts. Therefore
-the default values of `eglot-move-to-column-function` and
-`eglot-current-column-function` have been changed. The documentations
-of these variables help to restore the old behavior.
-
##### Support workspace/configuration requests ([#326][github#326])
Also a new section "Per-project server configuration" in the README.md
@@ -213,4 +205,3 @@ and now said bunch of references-->
[github#316]: https://github.com/joaotavora/eglot/issues/316
[github#324]: https://github.com/joaotavora/eglot/issues/324
[github#326]: https://github.com/joaotavora/eglot/issues/326
-[github#361]: https://github.com/joaotavora/eglot/issues/361
diff --git a/eglot.el b/eglot.el
index 5e83118..888eacc 100644
--- a/eglot.el
+++ b/eglot.el
@@ -999,15 +999,15 @@ CONNECT-ARGS are passed as additional arguments to
(defun eglot-current-column () (- (point) (point-at-bol)))
-(defvar eglot-current-column-function #'eglot-lsp-abiding-column
+(defvar eglot-current-column-function #'eglot-current-column
"Function to calculate the current column.
This is the inverse operation of
`eglot-move-to-column-function' (which see). It is a function of
no arguments returning a column number. For buffers managed by
fully LSP-compliant servers, this should be set to
-`eglot-lsp-abiding-column' (the default), and
-`eglot-current-column' for all others.")
+`eglot-lsp-abiding-column', and `eglot-current-column' (the default)
+for all others.")
(defun eglot-lsp-abiding-column ()
"Calculate current COLUMN as defined by the LSP spec."
@@ -1023,7 +1023,7 @@ fully LSP-compliant servers, this should be set to
:character (progn (when pos (goto-char pos))
(funcall eglot-current-column-function)))))
-(defvar eglot-move-to-column-function #'eglot-move-to-lsp-abiding-column
+(defvar eglot-move-to-column-function #'eglot-move-to-column
"Function to move to a column reported by the LSP server.
According to the standard, LSP column/character offsets are based
@@ -1033,8 +1033,8 @@ where X is a multi-byte character, it actually means `b',
not
`c'. However, many servers don't follow the spec this closely.
For buffers managed by fully LSP-compliant servers, this should
-be set to `eglot-move-to-lsp-abiding-column' (the default), and
-`eglot-move-to-column' for all others.")
+be set to `eglot-move-to-lsp-abiding-column', and
+`eglot-move-to-column' (the default) for all others.")
(defun eglot-move-to-column (column)
"Move to COLUMN without closely following the LSP spec."
- [elpa] externals/eglot 3879d57 33/54: * eglot.el (eglot-eldoc-function): Fix outdated docstring., (continued)
- [elpa] externals/eglot 3879d57 33/54: * eglot.el (eglot-eldoc-function): Fix outdated docstring., Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot a4c83a6 37/54: Merge pull request #400 from joaotavora/scratch/fix-277-exit-notification, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 7c48c7a 39/54: Document the changes in column calculation, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 2fdffef 41/54: Close #405: support bug-reference-prog-mode, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot ce53ca4 44/54: Close #315: introduce and use eglot--{}, the empty JSON object, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 73d3774 24/54: Fix #351: locally tweak imenu-create-index-function, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot b0fdfb0 30/54: Close #379: add built-in support for TeX and friends, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot c9fcbce 32/54: Close #383: add elm-language-server as the language server for Elm, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 4b453dc 35/54: Fix #389: avoid double shutdowns and simplify shutdown logic, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 633979e 38/54: Fix #361: abide by LSP when reporting and moving to columns, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot ae0943f 40/54: Revert the last change about column calculation,
Jo�o T�vora <=
- [elpa] externals/eglot e53dd5c 46/54: Per #354: make a public reader for project-nickname, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 4f6e152 51/54: Fix #430: send shutdown and exit messages without arguments, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 8332cdf 52/54: Fix eglot-move-to-lsp-abiding-column (#361), Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 864a493 50/54: Close #323: add a simple github issue template, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 4496657 34/54: Close #393: use completing-read in eglot-code-actions, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 9c52f24 36/54: Fix #277: Send exit as a notification, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 9f10a27 42/54: Explain the animations in the README, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot e02479a 54/54: * eglot.el (Version): Bump to 1.6, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 212a7f7 43/54: Per #315: call shutdown/exit methods with params:{}, not null, Jo�o T�vora, 2020/04/16
- [elpa] externals/eglot 8d8c90d 45/54: Fix #182: add public hook eglot-managed-mode-hook, Jo�o T�vora, 2020/04/16