emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/dash d7d0acb 242/316: Don't call eval


From: ELPA Syncer
Subject: [elpa] externals/dash d7d0acb 242/316: Don't call eval
Date: Mon, 15 Feb 2021 15:58:09 -0500 (EST)

branch: externals/dash
commit d7d0acb0e80c5206890b8e3d36f20159a14a96b1
Author: Basil L. Contovounesios <contovob@tcd.ie>
Commit: Basil L. Contovounesios <contovob@tcd.ie>

    Don't call eval
    
    * dev/examples-to-tests.el (example-to-should): No need to call
    eval.
    (defexamples, def-example-group): Tiny simplifications.
---
 dev/examples-to-tests.el | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/dev/examples-to-tests.el b/dev/examples-to-tests.el
index d0ca32a..efe22c0 100644
--- a/dev/examples-to-tests.el
+++ b/dev/examples-to-tests.el
@@ -29,13 +29,11 @@
         ((eq sym '~>)
          `(should (approx-equal ,actual ,expected)))
         ((eq sym '!!>)
-         `(should-error (eval ',actual) :type ',expected))
-        (t
-         (error "Invalid test case: %S" `(,actual ,sym ,expected)))))
-
+         `(should-error ,actual :type ',expected))
+        ((error "Invalid test case: %S" `(,actual ,sym ,expected)))))
 
 (defmacro defexamples (cmd &rest examples)
-  (let ((tests))
+  (let (tests)
     (while examples
       (push (example-to-should (pop examples)
                                (pop examples)
@@ -43,7 +41,7 @@
             tests))
     `(ert-deftest ,cmd () ,@(nreverse tests))))
 
-(defun def-example-group (&rest _)) ; ignore
+(defalias 'def-example-group #'ignore)
 
 (provide 'examples-to-tests)
 ;;; examples-to-tests.el ends here



reply via email to

[Prev in Thread] Current Thread [Next in Thread]