[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/ivy-hydra b7cb680 375/395: Remove unnecessary variable
From: |
Basil L. Contovounesios |
Subject: |
[elpa] externals/ivy-hydra b7cb680 375/395: Remove unnecessary variable declarations |
Date: |
Thu, 25 Feb 2021 08:32:42 -0500 (EST) |
branch: externals/ivy-hydra
commit b7cb6803e16d8800d946cfb6f41b9a9afc022b3a
Author: Brian Leung <leungbk@mailfence.com>
Commit: Oleh Krehel <ohwoeowho@gmail.com>
Remove unnecessary variable declarations
Fixes #2769
---
counsel.el | 28 +++++++++++++---------------
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/counsel.el b/counsel.el
index cfc1cd5..391452d 100644
--- a/counsel.el
+++ b/counsel.el
@@ -4770,9 +4770,11 @@ An extra action allows to switch to the process buffer."
(defvar eshell-history-index)
(defvar slime-repl-input-history-position)
-(defvar counsel-esh--index-last)
-(defvar counsel-shell-history--index-last)
-(defvar counsel-slime-repl-history--index-last)
+(defvar counsel-esh--index-last nil
+ "Index corresponding to last selection with `counsel-esh-history'.")
+
+(defvar counsel-shell-history--index-last nil
+ "Index corresponding to last selection with `counsel-shell-history'.")
(defun counsel--browse-history-action (pair)
(let ((snd (cdr pair)))
@@ -4783,9 +4785,12 @@ An extra action allows to switch to the process buffer."
(counsel-shell-history
(setq comint-input-ring-index snd
counsel-shell-history--index-last snd))
+ ;; Leave this as a no-op. If someone decides to patch
+ ;; `slime-repl-previous-input' or one of its utility functions,
+ ;; or to add history-replay to Slime, then this section can be
+ ;; updated to add the relevant support for those commands.
(counsel-slime-repl-history
- (setq slime-repl-input-history-position snd
- counsel-slime-repl-history--index-last snd)))
+ nil))
(ivy-completion-in-region-action (car pair))))
(cl-defun counsel--browse-history (ring &key caller)
@@ -4808,9 +4813,6 @@ An extra action allows to switch to the process buffer."
(defvar eshell-history-ring)
(defvar eshell-matching-input-from-input-string)
-(defvar counsel-esh--index-last nil
- "Index corresponding to last selection with `counsel-esh-history'.")
-
;;;###autoload
(defun counsel-esh-history ()
"Browse Eshell history."
@@ -4830,9 +4832,6 @@ An extra action allows to switch to the process buffer."
(defvar comint-input-ring)
(defvar comint-matching-input-from-input-string)
-(defvar counsel-shell-history--index-last nil
- "Index corresponding to last selection with `counsel-shell-history'.")
-
;;;###autoload
(defun counsel-shell-history ()
"Browse shell history."
@@ -4851,9 +4850,6 @@ An extra action allows to switch to the process buffer."
(defvar slime-repl-input-history)
-(defvar counsel-slime-repl-history--index-last nil
- "Index corresponding to last selection with `counsel-slime-repl-history'.")
-
;;;###autoload
(defun counsel-slime-repl-history ()
"Browse Slime REPL history."
@@ -4863,7 +4859,9 @@ An extra action allows to switch to the process buffer."
:caller #'counsel-slime-repl-history))
;; TODO: add advice for slime-repl-input-previous/next to properly
-;; reassign the ring index and match string
+;; reassign the ring index and match string. This requires a case for
+;; `counsel-slime-repl-history' within
+;; `counsel--browse-history-action'.
;;** `counsel-hydra-heads'
(defvar hydra-curr-body-fn)
- [elpa] externals/ivy-hydra 911a360 365/395: Consistently use modern face spec syntax, (continued)
- [elpa] externals/ivy-hydra 911a360 365/395: Consistently use modern face spec syntax, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 74f411d 355/395: Remove Emacs 28 workaround in counsel-descbinds, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 778d8bf 363/395: * counsel.el (counsel-org-files): Simplify regexp., Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra ab36ccb 364/395: * counsel.el (counsel-org-files): Fix regexp., Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra b65e401 351/395: counsel.el (counsel-file-jump-from-find): Add and bind to "`", Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra c6b60d3 337/395: counsel.el (counsel-ag): Prompt for args on a double universal-argument, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra d18ec97 338/395: counsel.el (compile-command): better handle our metadata, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra d321048 358/395: ivy.el (ivy-add-prompt-count): Simplify, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 96b433d 369/395: Handle Windows directory separator in ivy-occur, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra e43141d 373/395: ivy.el: Make sure swiper-isearch works with "M-r", Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra b7cb680 375/395: Remove unnecessary variable declarations,
Basil L. Contovounesios <=
- [elpa] externals/ivy-hydra cbce9ce 380/395: * ivy.el (ivy-rotate-sort): Also look up t., Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 25439e2 381/395: Don't modify user options without ivy-configure, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 8f2abd3 379/395: Switch between counsel-file-jump/counsel-find-file, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 8fb825d 382/395: Fix counsel-read-setq-expression, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 0965e23 386/395: Mention ignore alongside ivy-on-del-error-function, Basil L. Contovounesios, 2021/02/25