emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/denote 6b200b31ef 308/355: Simplify denote-dired--renam


From: ELPA Syncer
Subject: [elpa] externals/denote 6b200b31ef 308/355: Simplify denote-dired--rename-buffer
Date: Sun, 26 Jun 2022 23:58:35 -0400 (EDT)

branch: externals/denote
commit 6b200b31ef8ec51780a3febad5744d18c06936fe
Author: Damien Cassou <damien@cassou.me>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Simplify denote-dired--rename-buffer
    
    The new code is basically what `dired-rename-file' does.
---
 denote-dired.el | 16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

diff --git a/denote-dired.el b/denote-dired.el
index 1e10ae264e..026dc6f6bb 100644
--- a/denote-dired.el
+++ b/denote-dired.el
@@ -180,19 +180,9 @@ everything works as intended."
 
 (defun denote-dired--rename-buffer (old-name new-name)
   "Rename OLD-NAME buffer to NEW-NAME, when appropriate."
-  (when-let ((old-buf (find-buffer-visiting old-name)))
-    (with-current-buffer old-buf
-      ;; We get the window to replace the buffer without affecting the
-      ;; window layout.
-      (let ((win (get-buffer-window old-buf)))
-        (rename-buffer (file-name-nondirectory new-name))
-        ;; TODO 2022-06-17: Is there a better way to avoid duplication
-        ;; between old and new?  It seems wrong to kill-buffer and then
-        ;; find-file.
-        (kill-buffer (find-buffer-visiting old-name))
-        (when win
-          (with-selected-window win
-            (find-file new-name)))))))
+  (when-let* ((buffer (find-buffer-visiting old-name)))
+    (with-current-buffer buffer
+      (set-visited-file-name new-name nil t))))
 
 (defun denote-dired--rename-dired-file-or-prompt ()
   "Return Dired file at point, else prompt for one."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]