[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/denote f90f79f788 5/9: Make denote-link-fontify-backlin
From: |
ELPA Syncer |
Subject: |
[elpa] externals/denote f90f79f788 5/9: Make denote-link-fontify-backlinks obsolete |
Date: |
Wed, 26 Oct 2022 23:57:37 -0400 (EDT) |
branch: externals/denote
commit f90f79f788a71d98bf0ccb2ee17c88389d313bb9
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Make denote-link-fontify-backlinks obsolete
It will confuse users now that we have another option for displaying
the context of links. It is better to just handle this internally.
Furthermore, our fontification does not look nice when the context is
shown. In that case, the standard Xref style looks better because
it (i) clearly distinguishes file names from the context, (2) line
numbers from the context, and (3) highlights the matching identifier
on the given line.
Read the discussion on the mailing list about the refactoring of the
backlinks' buffer, with the participation of Noboru Ota:
<https://lists.sr.ht/~protesilaos/denote/%3C86r0yvzm12.fsf%40nobiot.com%3E>.
Also check the recent commit log for the relevant changes, including
patches from Noboru.
---
denote.el | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/denote.el b/denote.el
index be19190fc3..0633eda074 100644
--- a/denote.el
+++ b/denote.el
@@ -369,6 +369,8 @@ current note."
:package-version '(denote . "1.2.0")
:type 'boolean)
+(make-obsolete 'denote-link-fontify-backlinks 'denote-backlinks-show-context
"1.2.0")
+
;;;; Main variables
;; For character classes, evaluate: (info "(elisp) Char Classes")
@@ -2278,13 +2280,6 @@ Add this function to `dired-mode-hook'."
;;;;; User options
-(defcustom denote-link-fontify-backlinks t
- "When non-nil, apply faces to files in the backlinks' buffer."
- :type 'boolean
- :package-version '(denote . "0.1.0")
- :link '(info-link "(denote) The backlinks' buffer")
- :group 'denote-link)
-
(defcustom denote-link-backlinks-display-buffer-action
'((display-buffer-reuse-window display-buffer-below-selected)
(window-height . fit-window-to-buffer))
@@ -2614,7 +2609,7 @@ Expand `denote-link-backlinks-display-buffer-action'."
(define-derived-mode denote-backlinks-mode xref--xref-buffer-mode "Backlinks"
"Major mode for backlinks buffers."
- (when denote-link-fontify-backlinks
+ (unless denote-backlinks-show-context
(font-lock-add-keywords nil denote-faces-file-name-keywords-for-backlinks
t)))
(make-obsolete-variable 'denote-backlink-mode 'denote-backlinks-mode "0.6.0")
- [elpa] externals/denote updated (3b9bc00659 -> ee69daee74), ELPA Syncer, 2022/10/26
- [elpa] externals/denote bdc94d3369 2/9: Add user option to use original backlinks buffer or with context, ELPA Syncer, 2022/10/26
- [elpa] externals/denote bbdcc498a2 1/9: Fix 'denote-link-find-backlink', ELPA Syncer, 2022/10/26
- [elpa] externals/denote 7c22231457 8/9: Update minimum required Emacs version to 28.1, ELPA Syncer, 2022/10/26
- [elpa] externals/denote d304d79593 3/9: Reword denote--retrieve-files-in-xrefs doc string, ELPA Syncer, 2022/10/26
- [elpa] externals/denote 9b6cf70026 6/9: Add wrapper motions for backlinks' buffer, ELPA Syncer, 2022/10/26
- [elpa] externals/denote b313dfccaa 7/9: Update backlinks' buffer documentation in the manual, ELPA Syncer, 2022/10/26
- [elpa] externals/denote 3da08eac52 4/9: Reword denote-backlilnks-show-context docstring, ELPA Syncer, 2022/10/26
- [elpa] externals/denote f90f79f788 5/9: Make denote-link-fontify-backlinks obsolete,
ELPA Syncer <=
- [elpa] externals/denote ee69daee74 9/9: Update sample configuration, per b313dfc, ELPA Syncer, 2022/10/26