emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/bash-completion 43348d0be1 143/313: Bugfixes: remove refer


From: ELPA Syncer
Subject: [nongnu] elpa/bash-completion 43348d0be1 143/313: Bugfixes: remove references to nonexistent variables, such as
Date: Sat, 3 Dec 2022 10:59:25 -0500 (EST)

branch: elpa/bash-completion
commit 43348d0be1ec8608ea43b40fc010b13b30500d36
Author: Stephane Zermatten <szermatt@gmx.net>
Commit: Stephane Zermatten <szermatt@gmx.net>

    Bugfixes: remove references to nonexistent variables, such as
    bash-completion-open-quote, now that the mapcar hack to call
    bash-completion-fix is gone. Also a small fix for the test.
---
 bash-completion-test.el | 8 +-------
 bash-completion.el      | 9 ++-------
 2 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/bash-completion-test.el b/bash-completion-test.el
index a602cc08e6..7475c2d920 100644
--- a/bash-completion-test.el
+++ b/bash-completion-test.el
@@ -417,12 +417,6 @@ garbage
   (should (equal nil (bash-completion-starts-with "hello world" "hullo ")))
   (should (equal t (bash-completion-starts-with "hello" ""))))
 
-(ert-deftest bash-completion-ends-with-test ()
-  (should (equal nil (bash-completion-ends-with "" "world")))
-  (should (equal t (bash-completion-ends-with "hello world" "world")))
-  (should (equal nil (bash-completion-ends-with "hello world" "wurld")))
-  (should (equal t (bash-completion-ends-with "hello" ""))))
-
 (ert-deftest bash-completion-last-wordbreak-test ()
   (should (equal '("a:b:c:d:" "e" ?:)
                 (bash-completion-last-wordbreak-split "a:b:c:d:e")))
@@ -490,7 +484,7 @@ garbage
   ;; append / for home
   (should (equal "~/"
                  (bash-completion-fix (expand-file-name "~")
-                                      "~" "~" nil 'default)))
+                                      "~" "~" nil 'default nil)))
 
   (cl-letf (((symbol-function 'file-accessible-directory-p)
              (lambda (d)
diff --git a/bash-completion.el b/bash-completion.el
index d032e4dd57..2e0b470549 100644
--- a/bash-completion.el
+++ b/bash-completion.el
@@ -746,9 +746,7 @@ PARSED-PREFIX is replaced with UNPARSED-PREFIX in set fixed 
set
 of candidates.
 
 OPEN-QUOTE should be the quote that's still open in prefix.  A
-character (' or \") or nil.  If it is nil, the value of
-`bash-completion-open-quote' is used.  This allows
-calling this function from `mapcar'.
+character (' or \") or nil.  
 
 COMPLETION-TYPE describes the type of completion that was executed,
 as generated by `bash-completion-generate-line'. It is used to choose
@@ -766,10 +764,7 @@ Modification include:
 
 It should be invoked with the comint buffer as the current buffer
 for directory name detection to work."
-  (let ((parsed-prefix (or parsed-prefix bash-completion-parsed-prefix))
-        (unparsed-prefix (or unparsed-prefix bash-completion-unparsed-prefix))
-        (open-quote (or open-quote (and bash-completion-open-quote)))
-        (suffix "")
+  (let ((suffix "")
         (rest) ; the part between the prefix and the suffix
         (rebuilt))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]