emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/idris-mode 68fe8e115f 06/18: Move idris-list-compiler-note


From: ELPA Syncer
Subject: [nongnu] elpa/idris-mode 68fe8e115f 06/18: Move idris-list-compiler-notes into idris-commands.el
Date: Thu, 8 Dec 2022 05:59:07 -0500 (EST)

branch: elpa/idris-mode
commit 68fe8e115facf2ae02fc5a5ca30807c9f93c2991
Author: Marek L <nospam.keram@gmail.com>
Commit: Marek L <nospam.keram@gmail.com>

    Move idris-list-compiler-notes into idris-commands.el
    
    Why:
    Interactive functions should by convention be defined in the 
idris-commands.el
---
 idris-commands.el      |  6 ++++++
 idris-warnings-tree.el | 12 +++---------
 inferior-idris.el      |  2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/idris-commands.el b/idris-commands.el
index 7e000209f7..f69909c5f5 100644
--- a/idris-commands.el
+++ b/idris-commands.el
@@ -914,6 +914,12 @@ type-correct, so loading will fail."
   (interactive)
   (idris-hole-list-show (car (idris-eval '(:metavariables 80)))))
 
+(defun idris-list-compiler-notes ()
+  "Show the compiler notes in tree view."
+  (interactive)
+  (with-temp-message "Preparing compiler note tree..."
+    (idris-compiler-notes-list-show (reverse idris-raw-warnings))))
+
 (defun idris-kill-buffers ()
   (idris-warning-reset-all)
   (setq idris-currently-loaded-buffer nil)
diff --git a/idris-warnings-tree.el b/idris-warnings-tree.el
index bfb6b49f86..2236e8b417 100644
--- a/idris-warnings-tree.el
+++ b/idris-warnings-tree.el
@@ -33,7 +33,9 @@
 (require 'idris-common-utils)
 
 (defvar idris-notes-buffer-name (idris-buffer-name :notes)
-  "The name of the buffer containing Idris errors")
+  "The name of the buffer containing Idris errors.")
+
+(defvar idris-tree-printer 'idris-tree-default-printer)
 
 (defun idris-compiler-notes-list-show (notes)
   (if (null notes)
@@ -49,14 +51,6 @@
         (goto-char (point-min))))
     (display-buffer idris-notes-buffer-name)))
 
-(defun idris-list-compiler-notes ()
-  "Show the compiler notes in tree view."
-  (interactive)
-  (with-temp-message "Preparing compiler note tree..."
-    (idris-compiler-notes-list-show (reverse idris-raw-warnings))))
-
-(defvar idris-tree-printer 'idris-tree-default-printer)
-
 (defun idris-tree-for-note (note)
   (let* ((buttonp (> (length (nth 0 note)) 0)) ;; if empty source location
          (button-text `(,(format "%s line %s col %s:" (nth 0 note) (nth 1 
note) (nth 2 note))
diff --git a/inferior-idris.el b/inferior-idris.el
index 82ec295925..8c2ae7b89c 100644
--- a/inferior-idris.el
+++ b/inferior-idris.el
@@ -354,7 +354,7 @@ or FAILURE-CONT in failure case."
 (defvar idris-stack-eval-tags nil
   "List of stack-tags of continuations waiting on the stack.")
 
-(autoload 'idris-list-compiler-notes "idris-warnings-tree.el")
+(autoload 'idris-list-compiler-notes "idris-commands.el")
 (defun idris-eval (sexp &optional no-errors)
   "Evaluate EXPR on the inferior Idris and return the result,
 ignoring intermediate output. If `NO-ERRORS' is non-nil, don't



reply via email to

[Prev in Thread] Current Thread [Next in Thread]