[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/writegood-mode da662098e4 31/47: Fix issue of dynamically
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/writegood-mode da662098e4 31/47: Fix issue of dynamically updating regexes |
Date: |
Mon, 12 Dec 2022 21:01:42 -0500 (EST) |
branch: elpa/writegood-mode
commit da662098e439d1751855cdc0f38c5919974d5865
Author: Benjamin Beckwith <bnbeckwith@gmail.com>
Commit: Benjamin Beckwith <bnbeckwith@gmail.com>
Fix issue of dynamically updating regexes
This fixes an issue where a user could have added weasel words or
passive voice verbs and the regexes used would not have been updated to
handle the additional words.
They are now dynamic in nature and are updated upon entry into the minor
mode. This means any changes to the lists require a restart of
Writegood-mode.
---
writegood-mode.el | 37 +++++++++++++++++++------------------
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/writegood-mode.el b/writegood-mode.el
index 70df2cf1db..489763a1a1 100755
--- a/writegood-mode.el
+++ b/writegood-mode.el
@@ -2,7 +2,7 @@
;;
;; Author: Benjamin Beckwith
;; Created: 2010-8-12
-;; Version: 1.3
+;; Version: 2.1
;; Last-Updated: 2014-2-13
;; URL: http://github.com/bnbeckwith/writegood-mode
;; Keywords: writing weasel-words grammar
@@ -23,6 +23,7 @@
;;
;;; Change Log:
;;
+;; 2.1 Make user additions to word lists dynamic
;; 2.0 Flesch-Kincaid scoring added to functionality
;; 1.3 Several pull requests added, comments checked, passive voice regexp
fixed
;; 1.2 Fixed weasel-words regexp to have word boundaries
@@ -96,12 +97,12 @@
:group 'writegood
:type '(repeat string))
-(defvar writegood-weasels-font-lock-keywords-regexp
- (concat "\\b" (regexp-opt writegood-weasel-words) "\\b")
- "Matches weasel-words")
+(defun writegood-weasels-font-lock-keywords-regexp ()
+ "Generate regex that matches weasel-words"
+ (concat "\\b" (regexp-opt writegood-weasel-words) "\\b"))
-(defvar writegood-weasels-font-lock-keywords
- (list (list writegood-weasels-font-lock-keywords-regexp
+(defun writegood-weasels-font-lock-keywords ()
+ (list (list (writegood-weasels-font-lock-keywords-regexp)
0 (quote 'writegood-weasels-face) 'prepend)))
;; Passive Voice
@@ -145,14 +146,14 @@
:group 'writegood
:type '(repeat character))
-(defvar writegood-passive-voice-font-lock-keywords-regexp
+(defun writegood-passive-voice-font-lock-keywords-regexp ()
+ "Generate font-lock keywords regexp for passive-voice"
(concat
"\\b\\(am\\|are\\|were\\|being\\|is\\|been\\|was\\|be\\)\\b\\([[:space:]]\\|\\s<\\|\\s>\\)+\\([[:word:]]+ed\\|"
(regexp-opt writegood-passive-voice-irregulars)
- "\\)\\b")
- "Font-lock keywords regexp for passive-voice")
+ "\\)\\b"))
-(defvar writegood-passive-voice-font-lock-keywords
- (list (list writegood-passive-voice-font-lock-keywords-regexp
+(defun writegood-passive-voice-font-lock-keywords ()
+ (list (list (writegood-passive-voice-font-lock-keywords-regexp)
0 (quote 'writegood-passive-voice-face) 'prepend)))
;; Duplicates
@@ -168,7 +169,7 @@
"\\b\\([[:word:]]+\\)\\([[:space:]]\\|\\s<\\|\\s>\\)+\\1\\b"
"Font-lock keywords for duplicates")
-(defvar writegood-duplicates-font-lock-keywords
+(defun writegood-duplicates-font-lock-keywords ()
(list (list writegood-duplicates-font-lock-keywords-regexp
0 (quote 'writegood-duplicates-face) 'prepend)))
@@ -181,27 +182,27 @@
(defun writegood-weasels-turn-on ()
"Turn on syntax highlighting for weasels"
- (font-lock-add-keywords nil writegood-weasels-font-lock-keywords))
+ (font-lock-add-keywords nil (writegood-weasels-font-lock-keywords)))
(defun writegood-passive-voice-turn-on ()
"Turn on warnings for passive voice"
- (font-lock-add-keywords nil writegood-passive-voice-font-lock-keywords))
+ (font-lock-add-keywords nil (writegood-passive-voice-font-lock-keywords)))
(defun writegood-duplicates-turn-on ()
"Turn on warnings for duplicate words"
- (font-lock-add-keywords nil writegood-duplicates-font-lock-keywords))
+ (font-lock-add-keywords nil (writegood-duplicates-font-lock-keywords)))
(defun writegood-weasels-turn-off ()
"Turn on syntax highlighting for weasels"
- (font-lock-remove-keywords nil writegood-weasels-font-lock-keywords))
+ (font-lock-remove-keywords nil (writegood-weasels-font-lock-keywords)))
(defun writegood-passive-voice-turn-off ()
"Turn on warnings for passive voice"
- (font-lock-remove-keywords nil writegood-passive-voice-font-lock-keywords))
+ (font-lock-remove-keywords nil (writegood-passive-voice-font-lock-keywords)))
(defun writegood-duplicates-turn-off ()
"Turn on warnings for duplicate words"
- (font-lock-remove-keywords nil writegood-duplicates-font-lock-keywords))
+ (font-lock-remove-keywords nil (writegood-duplicates-font-lock-keywords)))
(defun writegood-turn-on ()
"Turn on writegood-mode."
- [nongnu] elpa/writegood-mode 62fa034d08 19/47: Merge pull request #4 from morphling/patch-1, (continued)
- [nongnu] elpa/writegood-mode 62fa034d08 19/47: Merge pull request #4 from morphling/patch-1, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 3db1a3bbf1 08/47: Added version const and function, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 1dba5de892 29/47: Updated README to highlight new functionality, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode d42e8f5500 37/47: Remove executable bit from README.org and writegood-mode.el, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode d54eadeedb 47/47: Add tooltips to detected text sections, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 599aed98f5 03/47: Fixed the link in the README to the original scripts, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 41d8a193c1 24/47: Flesch-Kincaid tests, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode c772829f30 10/47: Blocks of comments are now checked as well. (See Test Text for examples), ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 07275921a1 22/47: Merge pull request #6 from frankshearar/fix-nits, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 2dcba94eb2 33/47: Whitespaces, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode da662098e4 31/47: Fix issue of dynamically updating regexes,
ELPA Syncer <=
- [nongnu] elpa/writegood-mode 3c068f389e 23/47: Updated revision to 1.3, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 15f27658e5 28/47: Updated version string., ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode a99896531a 35/47: Update Artbollocks link, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 572fcbeab0 36/47: Fix Version and Last-Updated to use new policy, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 0bb65772a5 39/47: Add comment about Reading Ease Score, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 664667dbe3 41/47: Merge pull request #21 from zimoun/master, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode ed42d918d9 44/47: Update changelog, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 2ae759944a 45/47: Add additional custom regexps for weasel words and passive voice, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 9da42fc558 02/47: Added github urls, ELPA Syncer, 2022/12/12
- [nongnu] elpa/writegood-mode 273a8befd9 09/47: Changed defconst into defvar, ELPA Syncer, 2022/12/12